-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[REQ] Improve go-gin-server template #7280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The upcoming 5.0.0 version (major release) allows breaking change so we can include your changes into go-gin-server directly. Just that we need to highlight the breaking changes in the PR description to make people aware of these. I would suggest filing small PRs to target the requested features one by one to allow easier review and faster merge. |
@wing328 Thank you for your reply.
Good!
Okay, I'll focus on one thing by one PR as much as I can. |
@ash-r1 |
@wing328 I would like to propose new template of gin server, can I take this issue? I already have the implementation just need to open a PR. |
yes please |
I'm so sorry for ignoring the message. I hope @khizunov will do better 👍, Thanks. |
Hi, I'm gopher, as others already mentioned, go-gin-server has several issues.
I want to make points clear in this issue and discuss it.
Below is my suggestion as a gopher.
go
directory)shouldBind
or get parameter withgetParam
etc...I have my custom generator to achieve these points on my local already. I can refine it and make a PullReq if someone needs it.
Is it should have the same name or another?
go-gin-server2
?Please give me advice and opinion.
I think it's related to #1931 and #2752, #2803. But I filed this issue because these are somewhat outdated.
The text was updated successfully, but these errors were encountered: