-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[BUG][PHP] Too verbose PHPDoc blocks in each file #7530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Your suggestion to reduce duplicated comments sound good to me. |
Need to strip out comments mentioning the generator (or its team) as "authors", see: https://github.com/OpenAPITools/openapi-generator#34---license-information-on-generated-code |
The below is more for growth-hacking to introduce
Auto-generated code in other languages (e.g. Ruby) also put down "OpenAPI Generator team" as the |
@wing328 understandable, but since the code ships without a license by default, as established in #7535 and the generated code claims authorship by the generator team, that's at least something to consider. The generator can be mentioned without it (or its team) being explicitly called the authors of the generated code, those two things seem very different, but IANAL. Something like "generated with" instead of "author", the author is the user running the tool, no? |
Bug Report Checklist
Description
Current,y the
php
generator produces files with very large headers, close to or exceeding 40 lines. Not only is that way too verbose, it actually lowers the quality of the code since the signal/noise ratio is way off.This can also be seen in other places where the information is repeated in the PHPDoc block and immediately following it in code, bringing no value.
Solution proposals
partial_header.mustache
, one class level one, example below)Example
The text was updated successfully, but these errors were encountered: