fix(python): use legacy_implicit_noexcept to support old cython and fix #680

Signed-off-by: Benn Snyder <[email protected]>

Author: piedar

CMakeLists.txt

@@ -47,7 +47,7 @@ include (SetupDirectories)
 
 set (PROJECT_VER_MAJOR 0)
 set (PROJECT_VER_MINOR 7)
-set (PROJECT_VER_PATCH 1)
+set (PROJECT_VER_PATCH 2)
 set (PROJECT_VER
   "${PROJECT_VER_MAJOR}.${PROJECT_VER_MINOR}.${PROJECT_VER_PATCH}")
 set (PROJECT_APIVER

wrappers/python/CMakeLists.txt

@@ -37,6 +37,10 @@ add_custom_command(OUTPUT freenect${Python_BUILD_VERSION}.c
     ${CYTHON_EXECUTABLE}
       -${Python_BUILD_VERSION}
       -o freenect${Python_BUILD_VERSION}.c
+      # cython 3.0 needs certain functions to be marked noexcept
+      # but noexcept is not defined in old cython shipped in ubuntu 20.04
+      # todo: eventually require cython >= 0.29.31 and add proper noexcept without this workaround
+      -X legacy_implicit_noexcept=True
       "${CMAKE_CURRENT_SOURCE_DIR}/freenect.pyx")
 list(APPEND ADDITIONAL_MAKE_CLEAN_FILES freenect${Python_BUILD_VERSION}.c)
 

wrappers/python/freenect.pyx

@@ -322,7 +322,7 @@ cpdef open_device(CtxPtr ctx, int index):
 
 _depth_cb, _video_cb = None, None
 
-cdef void depth_cb(freenect_device *dev, void *data, uint32_t timestamp) noexcept with gil:
+cdef void depth_cb(freenect_device *dev, void *data, uint32_t timestamp) with gil:
     cdef freenect_frame_mode mode = freenect_get_current_depth_mode(dev)
     if not mode.is_valid:
         return
@@ -333,7 +333,7 @@ cdef void depth_cb(freenect_device *dev, void *data, uint32_t timestamp) noexcep
     pydata = _depth_cb_np(data, &mode)
     _depth_cb(dev_out, pydata, timestamp)
 
-cdef void video_cb(freenect_device *dev, void *data, uint32_t timestamp) noexcept with gil:
+cdef void video_cb(freenect_device *dev, void *data, uint32_t timestamp) with gil:
     cdef freenect_frame_mode mode = freenect_get_current_video_mode(dev)
     if not mode.is_valid:
         return