Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Ability to package custom instrument samples into .nbs file #239

Open
ItsOnlyKatniss opened this issue Apr 1, 2021 · 1 comment
Labels
C: NBS format change Suggestions or issues that require changes to the NBS format
Milestone

Comments

@ItsOnlyKatniss
Copy link

Would make it easier to share NBS files using custom instruments as you wouldn't have to share the sample files separately.

Would be useful for individual songs that use different samples with the same name.

@Bentroen Bentroen added the C: Enhancement New feature or request label Apr 2, 2021
@Bentroen
Copy link
Member

Bentroen commented Apr 2, 2021

Thanks for the suggestion! I've thought about this before, this would indeed make sharing songs a lot easier. The "Pack sounds to ZIP file" option added in 3.8.1 was intended to be an advancement in that direction, but I agree that packing everything into a single file would be even more convenient. Perhaps a middle-ground solution could be to package a ZIP file containing the .nbs file as well, not only the instruments.

If we ever do create a new file format for this purpose, it must be well thought-out: will the binary data of each sound file just be appended at the end of the current .nbs file structure, or will it be a different file type (maybe a ZIP file internally?) Also, will we keep the same file extension, or use a different one? (such as .nbsi?) And more importantly, would it be viable for plugins to take advantage of that new structure to simplify song loading? (Likely not, since songs are loaded server-side while resources are client-side). These are just some things to keep in mind if we do implement this in the future. :)

@Bentroen Bentroen added this to the v4.0 milestone Apr 17, 2021
@Bentroen Bentroen added C: NBS format change Suggestions or issues that require changes to the NBS format and removed C: Enhancement New feature or request labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: NBS format change Suggestions or issues that require changes to the NBS format
Projects
None yet
Development

No branches or pull requests

2 participants