Some misc near parallel UI changes (#1208)

* Change some icons around
* Add a tooltip
* Move default licensing arbitration to view instead of code... allows visual detection

Post #1204 #191 Loosely related to #116, and #944 via #970

Auto-merge

Author: Martii

controllers/script.js

@@ -148,8 +148,6 @@ var getScriptPageTasks = function (aOptions) {
     license.forEach(function (aElement, aIndex, aArray) {
       aOptions.script.licenses.unshift({ name: aElement.value });
     });
-  } else if (!script.isLib) {
-    aOptions.script.licenses = [{ name: 'MIT License (Expat)' }];
   }
 
   // Show collaborators of the script

views/includes/commentEditor.html

@@ -25,7 +25,7 @@
           </div>
           <section class="post-menu-area">
             <div class="submit-panel btn-toolbar">
-              <a href="/about/Frequently-Asked-Questions"><i class="fa fa-book"></i></a>
+              <a href="/about/Frequently-Asked-Questions"><i class="fa fa-question-circle" title="FAQ"></i></a>
               <a href="https://guides.github.com/features/mastering-markdown/" title="GitHub Flavor Markdown compatible"><i class="octicon octicon-markdown"></i></a>
               <button class="btn btn-sm btn-success pull-right" title="submit your comment" type="submit">
                 <i class="fa fa-fw fa-reply"></i> Submit

views/includes/commentForm.html

@@ -24,7 +24,7 @@
             <div class="container-fluid row user-content">
               <textarea name="comment-content" data-provide="markdown" data-iconlibrary="fa" class="col-xs-12" placeholder="Type here using Markdown." required="required"></textarea>
               <div class="submit-panel btn-toolbar">
-                <a href="/about/Frequently-Asked-Questions"><i class="fa fa-book"></i></a>
+                <a href="/about/Frequently-Asked-Questions"><i class="fa fa-question-circle" title="FAQ"></i></a>
                 <a href="https://guides.github.com/features/mastering-markdown/"><i class="octicon octicon-markdown" title="GitHub Flavor Markdown compatible"></i></a>
                 <button class="btn-sm btn btn-success pull-right" type="submit"><i class="fa fa-reply"></i> Reply</button>
               </div>

views/includes/scriptAuthorToolsPanel.html

@@ -19,7 +19,7 @@
           <a class="btn btn-{{#lockdown.updateURLCheck}}info{{/lockdown.updateURLCheck}}{{^lockdown.updateURLCheck}}default{{/lockdown.updateURLCheck}}"
             title="How do I use this?"
             href="/about/Frequently-Asked-Questions#q-does-openuserjs-org-have-meta-">
-              <i class="fa fa-{{#lockdown.updateURLCheck}}exclamation{{/lockdown.updateURLCheck}}{{^lockdown.updateURLCheck}}question{{/lockdown.updateURLCheck}}"></i>
+              <i class="fa fa-{{#lockdown.updateURLCheck}}exclamation-triangle{{/lockdown.updateURLCheck}}{{^lockdown.updateURLCheck}}question-circle{{/lockdown.updateURLCheck}}"></i>
           </a>
         </span>
       </div>

views/includes/scriptPageHeader.html

@@ -19,7 +19,7 @@ <h2 class="page-heading">
           {{/script.showMinficationNotices}}
         </li>
         <li role="separator" class="divider"></li>
-        <li><a href="/about/Userscript-Beginners-HOWTO"><em class="fa fa-fw fa-file-text-o"></em> Userscript Beginners HOWTO</a></li>
+        <li><a href="/about/Userscript-Beginners-HOWTO"><em class="fa fa-fw fa-question-circle"></em> Userscript Beginners HOWTO</a></li>
       </ul>
     </div>
     {{/script.isLib}}

views/pages/scriptPage.html

@@ -49,7 +49,8 @@
               {{#script.homepages}}<p><i class="fa fa-fw fa-home"></i> <b>Homepage:</b> <a href="{{{url}}}"{{#hasNoFollow}} rel="nofollow"{{/hasNoFollow}}>{{text}}</a></p>{{/script.homepages}}
               {{#script.support}}<p><i class="fa fa-fw fa-support"></i> <b>Support:</b> <a href="{{{url}}}"{{#hasNoFollow}} rel="nofollow"{{/hasNoFollow}}>{{text}}</a></p>{{/script.support}}
               {{#script.copyrights}}<p><i class="fa fa-fw fa-copyright"></i> <b>Copyright:</b> {{name}}</p>{{/script.copyrights}}
-              {{#script.licenses}}<p><i class="fa fa-fw fa-legal"></i> <b>License:</b> {{name}}</p>{{/script.licenses}}
+              {{#script.licenses}}<p><i class="fa fa-fw fa-balance-scale"></i> <b>License:</b> {{name}}</p>{{/script.licenses}}
+              {{^script.isLib}}{{^script.licenses}}<p><i class="fa fa-fw fa-legal"></i> <b>License:</b> MIT License (Expat)</p>{{/script.licenses}}{{/script.isLib}}
               {{#hasCollab}}
               <p><i class="fa fa-fw fa-user"></i> <b>Collaborator:</b> {{#script.collaborators}} <span class="label label-info"><a href="/users/{{{url}}}">{{text}}</a></span> {{/script.collaborators}}</p>
               {{/hasCollab}}