Graceful failure for invalid auth (#1372)

* Rather than just a 404 page... redirect to login page and denote with QSP when data present
* Some compliance with STYLEGUIDE.md max line length

Applies to #1369 and #37

Auto-merge

Author: Martii

controllers/auth.js

@@ -77,8 +77,9 @@ exports.auth = function (aReq, aRes, aNext) {
     var authenticate = null;
 
     // Just in case someone tries a bad /auth/* url
+    // or an auth has been EOL'd
     if (!strategyInstances[strategy]) {
-      aNext();
+      aRes.redirect('/login?invalidauth');
       return;
     }
 

controllers/user.js

@@ -890,7 +890,10 @@ exports.userEditPreferencesPage = function (aReq, aRes, aNext) {
           return aStrategy.display;
         });
 
-        options.defaultStrategy = strategies[defaultStrategy] ? strategies[defaultStrategy].name : null;
+        options.defaultStrategy = strategies[defaultStrategy]
+          ? strategies[defaultStrategy].name
+          : null;
+
         options.defaultStrat = defaultStrategy;
         options.haveOtherStrategies = options.usedStrategies.length > 0;