Skip to content

Commit a6c8116

Browse files
authored
Always show the comment reply form (#1615)
* Allows some browser back button to work in certain browsers due to logoff condition. Edge use case. NOTE: * This is a **work-around** for those browsers not implementing back-browser action in a consistent non-destructive manner. Currently present in Chromium back-ends but not Mozilla based or Safari based. Nice inconsistency google! Perhaps this is a bug to add to their collection. Probable refetch instead of cache pull *(and listen)* in those affected browsers which can be another imposed DoS vector. * No known current way, w/o additional DoS vector added, to address for newTopic logoff condition e.g. out of luck atm. Post #1204 Refs: * https://openuserjs.org/scripts/AltoRetrato/IMDb_My_Movies_enhancer/issues/does_it_still_work!#comment-16af97e508e *(subtle report not yet done on development)* * https://stackoverflow.com/questions/39920118/chrome-forces-page-refresh-on-window-history-back *(unanswered and long time issue)* * #1548 (comment) *(about:flags note ... perhaps there is another one to disable bad browser acting)* Auto-merge
1 parent e303db4 commit a6c8116

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

views/includes/commentForm.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<div class="submit-panel btn-toolbar">
2727
<a href="/about/Frequently-Asked-Questions"><i class="fa fa-question-circle" title="FAQ"></i></a>
2828
<a href="https://guides.github.com/features/mastering-markdown/"><i class="octicon octicon-markdown" title="GitHub Flavor Markdown compatible"></i></a>
29-
<button class="btn-sm btn btn-success pull-right" type="submit"><i class="fa fa-reply"></i> Reply</button>
29+
<button class="btn-sm btn btn-success pull-right" type="submit" {{^authedUser}}disabled="disabled"{{/authedUser}}><i class="fa fa-reply"></i> Reply</button>
3030
</div>
3131
</div>
3232
</form>

views/pages/discussionPage.html

+2-6
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,9 @@
3636
</div>
3737
{{/paginationRendered}}
3838
</section>
39-
{{#authedUser}}
4039
<section class="topic-area list-group">
4140
{{> includes/commentForm.html }}
4241
</section>
43-
{{/authedUser}}
4442
</div>
4543
</div>
4644
</div>
@@ -57,10 +55,8 @@
5755
{{> includes/scripts/showTopPagination.html }}
5856
{{/paginationRendered}}
5957
{{> includes/scripts/formControlClear.html }}
60-
{{#authedUser}}
61-
{{> includes/scripts/markdownEditor.html }}
62-
{{> includes/scripts/commentReplyScript.html }}
63-
{{/authedUser}}
58+
{{> includes/scripts/markdownEditor.html }}
59+
{{> includes/scripts/commentReplyScript.html }}
6460
{{^authedUser}}
6561
{{> includes/scripts/commentReplyTooltip.html }}
6662
{{/authedUser}}

views/pages/scriptIssuePage.html

+2-4
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,8 @@
7979
{{/paginationRendered}}
8080
{{> includes/scripts/lazyIconScript.html }}
8181
{{> includes/scripts/formControlClear.html }}
82-
{{#authedUser}}
83-
{{> includes/scripts/markdownEditor.html }}
84-
{{> includes/scripts/commentReplyScript.html }}
85-
{{/authedUser}}
82+
{{> includes/scripts/markdownEditor.html }}
83+
{{> includes/scripts/commentReplyScript.html }}
8684
{{^authedUser}}
8785
{{> includes/scripts/commentReplyTooltip.html }}
8886
{{/authedUser}}

0 commit comments

Comments
 (0)