Skip to content

Commit 230b272

Browse files
committed
deep bignumber comparison removed
1 parent ed4d72a commit 230b272

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

test/token/ERC721/ERC721.behavior.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@ const { ZERO_ADDRESS } = require('../../helpers/constants');
55
const send = require('../../helpers/send');
66

77
const ERC721ReceiverMock = artifacts.require('ERC721ReceiverMock.sol');
8-
const { BigNumber } = require('../../helpers/setup');
8+
require('../../helpers/setup');
99

1010
function shouldBehaveLikeERC721 (
1111
creator,
1212
minter,
1313
[owner, approved, anotherApproved, operator, anyone]
1414
) {
15-
const firstTokenId = new BigNumber(1);
16-
const secondTokenId = new BigNumber(2);
17-
const unknownTokenId = new BigNumber(3);
15+
const firstTokenId = 1;
16+
const secondTokenId = 2;
17+
const unknownTokenId = 3;
1818
const RECEIVER_MAGIC_VALUE = '0x150b7a02';
1919

2020
describe('like an ERC721', function () {
@@ -173,7 +173,7 @@ function shouldBehaveLikeERC721 (
173173
const tokensListed = await Promise.all(
174174
[0, 1].map(i => this.token.tokenOfOwnerByIndex(owner, i))
175175
);
176-
tokensListed.should.have.deep.members([firstTokenId, secondTokenId]);
176+
tokensListed.map(t => t.toNumber()).should.have.members([firstTokenId, secondTokenId]);
177177
});
178178
});
179179

test/token/ERC721/ERC721Full.test.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ contract('ERC721Full', function ([
1212
]) {
1313
const name = 'Non Fungible Token';
1414
const symbol = 'NFT';
15-
const firstTokenId = new BigNumber(100);
16-
const secondTokenId = new BigNumber(200);
17-
const thirdTokenId = new BigNumber(300);
18-
const nonExistentTokenId = new BigNumber(999);
15+
const firstTokenId = 100;
16+
const secondTokenId = 200;
17+
const thirdTokenId = 300;
18+
const nonExistentTokenId = 999;
1919

2020
const minter = creator;
2121

@@ -149,7 +149,7 @@ contract('ERC721Full', function ([
149149
const tokensListed = await Promise.all(
150150
[0, 1].map(i => this.token.tokenOfOwnerByIndex(another, i))
151151
);
152-
tokensListed.should.have.deep.members([firstTokenId, secondTokenId]);
152+
tokensListed.map(t => t.toNumber()).should.have.members([firstTokenId, secondTokenId]);
153153
});
154154

155155
it('returns empty collection for original owner', async function () {
@@ -164,7 +164,7 @@ contract('ERC721Full', function ([
164164
const tokensListed = await Promise.all(
165165
[0, 1].map(i => this.token.tokenByIndex(i))
166166
);
167-
tokensListed.should.have.deep.members([firstTokenId, secondTokenId]);
167+
tokensListed.map(t => t.toNumber()).should.have.members([firstTokenId, secondTokenId]);
168168
});
169169

170170
it('should revert if index is greater than supply', async function () {
@@ -188,7 +188,7 @@ contract('ERC721Full', function ([
188188
const expectedTokens = [firstTokenId, secondTokenId, newTokenId, anotherNewTokenId].filter(
189189
x => (x !== tokenId)
190190
);
191-
tokensListed.should.have.deep.members(expectedTokens);
191+
tokensListed.map(t => t.toNumber()).should.have.members(expectedTokens);
192192
});
193193
});
194194
});

0 commit comments

Comments
 (0)