Skip to content

Improve SafeMath tests #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frangio opened this issue Dec 18, 2018 · 0 comments
Closed

Improve SafeMath tests #1563

frangio opened this issue Dec 18, 2018 · 0 comments
Labels
tests Test suite and helpers.
Milestone
v2.2

Comments

@frangio
Copy link
Contributor

frangio commented Dec 18, 2018

The SafeMath tests need some love. We should add a helper to test all operations behave the same way when their arguments are swapped. And we should make sure to be testing all edge cases.
@frangio frangio added the tests Test suite and helpers. label Dec 18, 2018
@frangio frangio added this to the v2.2 milestone Dec 18, 2018
@frangio frangio mentioned this issue Dec 18, 2018
Merged
@nventuro nventuro mentioned this issue Jan 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Test suite and helpers.
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
1 participant
@frangio