Skip to content

Review operators in internal interface of ERC777 #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frangio opened this issue Mar 13, 2020 · 0 comments · Fixed by #2134
Closed

Review operators in internal interface of ERC777 #2121

frangio opened this issue Mar 13, 2020 · 0 comments · Fixed by #2134
Labels
breaking change Changes that break backwards compatibility of the public API.
Milestone

Comments

@frangio
Copy link
Contributor

frangio commented Mar 13, 2020

We've discussed before whether the internal interface of ERC777 should allow arbitrary operator (see _mint for an example). There is some new reasoning to reconsider always setting operator to msg.sender in #2112 (comment).

My feeling is it is more useful to always log msg.sender. Even if the granting was done through logic of the contract, I think for auditing/monitoring purposes it's more relevant to know who triggered it.

@frangio frangio added the breaking change Changes that break backwards compatibility of the public API. label Mar 13, 2020
@frangio frangio added this to the v3.0 milestone Mar 13, 2020
@frangio frangio changed the title Review internal interface of ERC777 Review operators in internal interface of ERC777 Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant