Skip to content

Implement ERC 1167, Clone Factory #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
shrugs opened this issue Aug 8, 2018 · 3 comments
Closed
1 task done

Implement ERC 1167, Clone Factory #1162

shrugs opened this issue Aug 8, 2018 · 3 comments
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.

Comments

@shrugs
Copy link
Contributor

shrugs commented Aug 8, 2018

🎉 Description

When 1167 is finalized in the new week, it'd be good to have an OpenZeppelin implementation.

https://eips.ethereum.org/EIPS/eip-1167

  • 📈 This is a feature request.
@shrugs shrugs self-assigned this Aug 8, 2018
@shrugs shrugs removed their assignment Aug 8, 2018
@nventuro nventuro added feature New contracts, functions, or helpers. help wanted contracts Smart contract code. labels Aug 8, 2018
@jbogacz
Copy link
Contributor

jbogacz commented Sep 20, 2018

Hey folks, I'd like to take care of this if it's still not touched.

@nventuro
Copy link
Contributor

@jbogacz go ahead! I'll gladly review your contribution once it's done :)

@nventuro
Copy link
Contributor

After much discussion, we've decided tooling is not yet ready to get something like this into OpenZeppelin. There are too many caveats related to proxies (e.g. constructors, self-destruct) that allow for easy misuse, which go against our design principles.

Having some sort of way to retrieve the constructor of a contract type at compile time, check for self destruction, etc., would allow for this to be safely implemented, at which point we will reconsider including this in the library.

Closing the issue until such a time comes 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants