Skip to content

Commit 7235617

Browse files
committedNov 10, 2023
Fix memory leak when applying image effects
1 parent 39c88ce commit 7235617

11 files changed

+0
-14
lines changed
 

‎src/UI/Dialogs/ImageEffects/DesaturateDialog.gd

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
2828
else:
2929
var gen := ShaderImageEffect.new()
3030
gen.generate_image(cel, shader, params, project.size)
31-
yield(gen, "done")
3231

3332

3433
func _on_RButton_toggled(button_pressed: bool) -> void:

‎src/UI/Dialogs/ImageEffects/DropShadowDialog.gd

-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
4141
else:
4242
var gen := ShaderImageEffect.new()
4343
gen.generate_image(cel, shader, params, project.size)
44-
yield(gen, "done")
4544

4645

4746
func _on_OffsetSliders_value_changed(_value: Vector2) -> void:

‎src/UI/Dialogs/ImageEffects/GradientDialog.gd

-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
124124
else:
125125
var gen := ShaderImageEffect.new()
126126
gen.generate_image(cel, shader, params, project.size)
127-
yield(gen, "done")
128127

129128

130129
func _on_ShapeOptionButton_item_selected(index: int) -> void:

‎src/UI/Dialogs/ImageEffects/GradientMapDialog.gd

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
2222
else:
2323
var gen := ShaderImageEffect.new()
2424
gen.generate_image(cel, shader, params, project.size)
25-
yield(gen, "done")
2625

2726

2827
func _on_GradientEdit_updated(_gradient, _cc) -> void:

‎src/UI/Dialogs/ImageEffects/HSVDialog.gd

-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
3838
else:
3939
var gen := ShaderImageEffect.new()
4040
gen.generate_image(cel, shader, params, project.size)
41-
yield(gen, "done")
4241

4342

4443
func _reset() -> void:

‎src/UI/Dialogs/ImageEffects/InvertColorsDialog.gd

-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
2929
else:
3030
var gen := ShaderImageEffect.new()
3131
gen.generate_image(cel, shader, params, project.size)
32-
yield(gen, "done")
3332

3433

3534
func _on_RButton_toggled(button_pressed: bool) -> void:

‎src/UI/Dialogs/ImageEffects/OffsetImage.gd

-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
4242
else:
4343
var gen := ShaderImageEffect.new()
4444
gen.generate_image(cel, shader, params, project.size)
45-
yield(gen, "done")
4645

4746

4847
func _on_OffsetSliders_value_changed(_value: Vector2) -> void:

‎src/UI/Dialogs/ImageEffects/OutlineDialog.gd

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
5050
else:
5151
var gen := ShaderImageEffect.new()
5252
gen.generate_image(cel, shader, params, project.size)
53-
yield(gen, "done")
5453

5554

5655
func _on_ThickValue_value_changed(value: int) -> void:

‎src/UI/Dialogs/ImageEffects/Posterize.gd

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
2424
else:
2525
var gen := ShaderImageEffect.new()
2626
gen.generate_image(cel, shader, params, project.size)
27-
yield(gen, "done")
2827

2928

3029
func _on_LevelsSlider_value_changed(value: float) -> void:

‎src/UI/Dialogs/ImageEffects/RotateImage.gd

-4
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ func commit_action(cel: Image, _project: Project = Global.current_project) -> vo
128128
else:
129129
var gen := ShaderImageEffect.new()
130130
gen.generate_image(cel, rotxel_shader, params, _project.size)
131-
yield(gen, "done")
132131

133132
CLEANEDGE:
134133
var params := {
@@ -147,7 +146,6 @@ func commit_action(cel: Image, _project: Project = Global.current_project) -> vo
147146
params["preview"] = false
148147
var gen := ShaderImageEffect.new()
149148
gen.generate_image(cel, DrawingAlgos.clean_edge_shader, params, _project.size)
150-
yield(gen, "done")
151149
OMNISCALE:
152150
var params := {
153151
"angle": angle,
@@ -163,7 +161,6 @@ func commit_action(cel: Image, _project: Project = Global.current_project) -> vo
163161
params["preview"] = false
164162
var gen := ShaderImageEffect.new()
165163
gen.generate_image(cel, DrawingAlgos.omniscale_shader, params, _project.size)
166-
yield(gen, "done")
167164
NNS:
168165
var params := {
169166
"angle": angle,
@@ -177,7 +174,6 @@ func commit_action(cel: Image, _project: Project = Global.current_project) -> vo
177174
else:
178175
var gen := ShaderImageEffect.new()
179176
gen.generate_image(cel, nn_shader, params, _project.size)
180-
yield(gen, "done")
181177
ROTXEL:
182178
DrawingAlgos.rotxel(image, angle, pivot)
183179
NN:

‎src/UI/Dialogs/ImageEffects/ShaderEffect.gd

-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
3030
var gen := ShaderImageEffect.new()
3131
gen.generate_image(cel, shader, params, project.size)
3232
selected_cels.unlock()
33-
yield(gen, "done")
3433

3534

3635
func _on_ChooseShader_pressed() -> void:

0 commit comments

Comments
 (0)
Please sign in to comment.