Skip to content

Commit 1d256d1

Browse files
authored
Merge pull request #359 from rodrigoprimo/changelog-improvements-3-5-2
Add links to all issues in the 3.5.3 and 3.5.2 sections of the changelog
2 parents 54f81f2 + 3ae055e commit 1d256d1

File tree

1 file changed

+35
-18
lines changed

1 file changed

+35
-18
lines changed

CHANGELOG.md

+35-18
Original file line numberDiff line numberDiff line change
@@ -1117,7 +1117,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
11171117
- The double arrow becomes the scope opener, and uses a new T_FN_ARROW token type
11181118
- The token after the statement (normally a semicolon) becomes the scope closer
11191119
- The token is also associated with the opening and closing parenthesis of the statement
1120-
- Any functions named "fn" will cause have a T_FN token for the function name, but have no scope information
1120+
- Any functions named "fn" will have a T_FN token for the function name, but have no scope information
11211121
- Thanks to [Michał Bundyra][@michalbundyra] for the help with this change
11221122
- PHP 7.4 numeric separators are now tokenized in the same way when using older PHP versions
11231123
- Previously, a number like 1_000 would tokenize as T_LNUMBER (1), T_STRING (_000)
@@ -1153,24 +1153,34 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
11531153
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
11541154

11551155
### Fixed
1156-
- Fixed bug #2586 : Generic.WhiteSpace.ScopeIndent false positives when indenting open tags at a non tab-stop
1157-
- Fixed bug #2638 : Squiz.CSS.DuplicateClassDefinitionSniff sees comments as part of the class name
1156+
- Fixed bug [#2586] : Generic.WhiteSpace.ScopeIndent false positives when indenting open tags at a non tab-stop
1157+
- Fixed bug [#2638] : Squiz.CSS.DuplicateClassDefinitionSniff sees comments as part of the class name
11581158
- Thanks to [Raphael Horber][@rhorber] for the patch
1159-
- Fixed bug #2640 : Squiz.WhiteSpace.OperatorSpacing false positives for some negation operators
1159+
- Fixed bug [#2640] : Squiz.WhiteSpace.OperatorSpacing false positives for some negation operators
11601160
- Thanks to [Jakub Chábek][@grongor] and [Juliette Reinders Folmer][@jrfnl] for the patch
1161-
- Fixed bug #2674 : Squiz.Functions.FunctionDeclarationArgumentSpacing prints wrong argument name in error message
1162-
- Fixed bug #2676 : PSR12.Files.FileHeader locks up when file ends with multiple inline comments
1163-
- Fixed bug #2678 : PSR12.Classes.AnonClassDeclaration incorrectly enforcing that closing brace be on a line by itself
1164-
- Fixed bug #2685 : File::getMethodParameters() setting typeHintEndToken for vars with no type hint
1161+
- Fixed bug [#2674] : Squiz.Functions.FunctionDeclarationArgumentSpacing prints wrong argument name in error message
1162+
- Fixed bug [#2676] : PSR12.Files.FileHeader locks up when file ends with multiple inline comments
1163+
- Fixed bug [#2678] : PSR12.Classes.AnonClassDeclaration incorrectly enforcing that closing brace be on a line by itself
1164+
- Fixed bug [#2685] : File::getMethodParameters() setting typeHintEndToken for vars with no type hint
11651165
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1166-
- Fixed bug #2694 : AbstractArraySniff produces invalid indices when using ternary operator
1166+
- Fixed bug [#2694] : AbstractArraySniff produces invalid indices when using ternary operator
11671167
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
1168-
- Fixed bug #2702 : Generic.WhiteSpace.ScopeIndent false positive when using ternary operator with short arrays
1168+
- Fixed bug [#2702] : Generic.WhiteSpace.ScopeIndent false positive when using ternary operator with short arrays
1169+
1170+
[#2586]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2586
1171+
[#2638]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2638
1172+
[#2640]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2640
1173+
[#2674]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2674
1174+
[#2676]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2676
1175+
[#2678]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2678
1176+
[#2685]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2685
1177+
[#2694]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2694
1178+
[#2702]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2702
11691179

11701180
## [3.5.2] - 2019-10-28
11711181
### Changed
11721182
- Generic.ControlStructures.DisallowYodaConditions now returns less false positives
1173-
- False positives were being returned for array comparisions, or when performing some function calls
1183+
- False positives were being returned for array comparisons, or when performing some function calls
11741184
- Squiz.WhiteSpace.SemicolonSpacing.Incorrect error message now escapes newlines and tabs
11751185
- Provides a clearer error message as whitespace is now visible
11761186
- Also allows for better output for report types such as CSV and XML
@@ -1179,13 +1189,20 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
11791189
- Thanks to [Craig Duncan][@duncan3dc] for the patch
11801190

11811191
### Fixed
1182-
- Fixed bug #2654 : Incorrect indentation for arguments of multiline function calls
1183-
- Fixed bug #2656 : Squiz.WhiteSpace.MemberVarSpacing removes comments before first member var during auto fixing
1184-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1185-
- Fixed bug #2663 : Generic.NamingConventions.ConstructorName complains about old constructor in interfaces
1186-
- Fixed bug #2664 : PSR12.Files.OpenTag incorrectly identifies PHP file with only an opening tag
1187-
- Fixed bug #2665 : PSR12.Files.ImportStatement should not apply to traits
1188-
- Fixed bug #2673 : PSR12.Traits.UseDeclaration does not allow comments or blank lines between use statements
1192+
- Fixed bug [#2654] : Incorrect indentation for arguments of multiline function calls
1193+
- Fixed bug [#2656] : Squiz.WhiteSpace.MemberVarSpacing removes comments before first member var during auto fixing
1194+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1195+
- Fixed bug [#2663] : Generic.NamingConventions.ConstructorName complains about old constructor in interfaces
1196+
- Fixed bug [#2664] : PSR12.Files.OpenTag incorrectly identifies PHP file with only an opening tag
1197+
- Fixed bug [#2665] : PSR12.Files.ImportStatement should not apply to traits
1198+
- Fixed bug [#2673] : PSR12.Traits.UseDeclaration does not allow comments or blank lines between use statements
1199+
1200+
[#2654]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2654
1201+
[#2656]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2656
1202+
[#2663]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2663
1203+
[#2664]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2664
1204+
[#2665]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2665
1205+
[#2673]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2673
11891206

11901207
## [3.5.1] - 2019-10-17
11911208
### Changed

0 commit comments

Comments
 (0)