Merge pull request #1077 from PHPCSStandards/feature/config-bug-report-file-vs-phpcbf

Config: bug fix - "reports" could get set incorrectly when in CBF mode

Author: jrfnl

src/Config.php

@@ -1010,8 +1010,8 @@ public function processLongArgument($arg, $pos)
                 }
 
                 self::$overriddenDefaults['stdinPath'] = true;
-            } else if (PHP_CODESNIFFER_CBF === false && substr($arg, 0, 12) === 'report-file=') {
-                if (isset(self::$overriddenDefaults['reportFile']) === true) {
+            } else if (substr($arg, 0, 12) === 'report-file=') {
+                if (PHP_CODESNIFFER_CBF === true || isset(self::$overriddenDefaults['reportFile']) === true) {
                     break;
                 }
 

tests/Core/Config/ReportArgsTest.php

@@ -0,0 +1,64 @@
+<?php
+/**
+ * Tests for the \PHP_CodeSniffer\Config --report, --report-file and --report-* arguments.
+ *
+ * @copyright 2025 PHPCSStandards and contributors
+ * @license   https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
+ */
+
+namespace PHP_CodeSniffer\Tests\Core\Config;
+
+use PHP_CodeSniffer\Tests\ConfigDouble;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Tests for the \PHP_CodeSniffer\Config --report, --report-file and --report-* arguments.
+ *
+ * @covers \PHP_CodeSniffer\Config::processLongArgument
+ */
+final class ReportArgsTest extends TestCase
+{
+
+
+    /**
+     * [CS mode] Verify that passing `--report-file` does not influence *which* reports get activated.
+     *
+     * @return void
+     */
+    public function testReportFileDoesNotSetReportsCs()
+    {
+        if (PHP_CODESNIFFER_CBF === true) {
+            $this->markTestSkipped('This test needs CS mode to run');
+        }
+
+        $config = new ConfigDouble(['--report-file='.__DIR__.'/report.txt']);
+
+        $this->assertTrue(is_string($config->reportFile));
+        $this->assertStringEndsWith('/report.txt', $config->reportFile);
+        $this->assertSame(['full' => null], $config->reports);
+
+    }//end testReportFileDoesNotSetReportsCs()
+
+
+    /**
+     * [CBF mode] Verify that passing `--report-file` does not influence *which* reports get activated.
+     *
+     * @group CBF
+     *
+     * @return void
+     */
+    public function testReportFileDoesNotSetReportsCbf()
+    {
+        if (PHP_CODESNIFFER_CBF === false) {
+            $this->markTestSkipped('This test needs CBF mode to run');
+        }
+
+        $config = new ConfigDouble(['--report-file='.__DIR__.'/report.txt']);
+
+        $this->assertNull($config->reportFile);
+        $this->assertSame(['full' => null], $config->reports);
+
+    }//end testReportFileDoesNotSetReportsCbf()
+
+
+}//end class