Skip to content

Commit f81f12f

Browse files
committed
Combine the two existing abstract classes into one
1 parent 7f874e3 commit f81f12f

File tree

2 files changed

+13
-15
lines changed

2 files changed

+13
-15
lines changed

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.1.inc

+9-11
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,15 @@ class Bar {
8383

8484
abstract class AbstractFoo {
8585
abstract public function sniffShouldBailEarly();
86+
87+
public function uselessMethodInAbstractClass() {
88+
parent::uselessMethodInAbstractClass();
89+
}
90+
91+
public function usefulMethodInAbstractClass() {
92+
$a = 1;
93+
parent::usefulMethodInAbstractClass($a);
94+
}
8695
}
8796

8897
interface InterfaceFoo {
@@ -103,17 +112,6 @@ trait TraitFoo {
103112
}
104113
}
105114

106-
abstract class AbstractBar extends AbstractFoo {
107-
public function uselessMethodInAbstractClass() {
108-
parent::uselessMethodInAbstractClass();
109-
}
110-
111-
public function usefulMethodInAbstractClass() {
112-
$a = 1;
113-
parent::usefulMethodInAbstractClass($a);
114-
}
115-
}
116-
117115
enum EnumFoo {
118116
public function sniffShouldBailEarly() {
119117
// Invalid code needed to ensure an error is NOT triggered and the sniff bails early when handling an enum method.

src/Standards/Generic/Tests/CodeAnalysis/UselessOverridingMethodUnitTest.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ public function getWarningList($testFile='')
5555
38 => 1,
5656
56 => 1,
5757
68 => 1,
58-
101 => 1,
59-
107 => 1,
60-
130 => 1,
61-
142 => 1,
58+
87 => 1,
59+
110 => 1,
60+
128 => 1,
61+
140 => 1,
6262
];
6363
default:
6464
return [];

0 commit comments

Comments
 (0)