Initial work on supporting Freeze Pane for Ods Writer

Author: MarkBaker

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
 
 ### Added
 
+- Ods Writer support for Freeze Pane [Issue #2013](https://github.com/PHPOffice/PhpSpreadsheet/issues/2013) [PR #2755](https://github.com/PHPOffice/PhpSpreadsheet/pull/2755)
 - Ods Writer support for setting column width/row height (including the use of AutoSize) [Issue #2346](https://github.com/PHPOffice/PhpSpreadsheet/issues/2346) [PR #2753](https://github.com/PHPOffice/PhpSpreadsheet/pull/2753)
 - Introduced CellAddress, CellRange, RowRange and ColumnRange value objects that can be used as an alternative to a string value (e.g. `'C5'`, `'B2:D4'`, `'2:2'` or `'B:C'`) in appropriate contexts.
 - Implementation of the FILTER(), SORT(), SORTBY() and UNIQUE() Lookup/Reference (array) functions.

phpstan-baseline.neon

@@ -4690,11 +4690,6 @@ parameters:
 			count: 1
 			path: src/PhpSpreadsheet/Writer/Ods/Formula.php
 
-		-
-			message: "#^Parameter \\#1 \\$content of method XMLWriter\\:\\:text\\(\\) expects string, int given\\.$#"
-			count: 2
-			path: src/PhpSpreadsheet/Writer/Ods/Settings.php
-
 		-
 			message: "#^Cannot call method getHashCode\\(\\) on PhpOffice\\\\PhpSpreadsheet\\\\Style\\\\Font\\|null\\.$#"
 			count: 1

src/PhpSpreadsheet/Writer/Ods/Settings.php

@@ -3,9 +3,9 @@
 namespace PhpOffice\PhpSpreadsheet\Writer\Ods;
 
 use PhpOffice\PhpSpreadsheet\Cell\CellAddress;
-use PhpOffice\PhpSpreadsheet\Spreadsheet;
 use PhpOffice\PhpSpreadsheet\Cell\Coordinate;
 use PhpOffice\PhpSpreadsheet\Shared\XMLWriter;
+use PhpOffice\PhpSpreadsheet\Spreadsheet;
 use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
 
 class Settings extends WriterPart
@@ -99,16 +99,16 @@ private function writeSelectedCells(XMLWriter $objWriter, Worksheet $worksheet):
         $selected = $worksheet->getSelectedCells();
         if (preg_match('/^([a-z]+)([0-9]+)/i', $selected, $matches) === 1) {
             $colSel = Coordinate::columnIndexFromString($matches[1]) - 1;
-            $rowSel = (int)$matches[2] - 1;
+            $rowSel = (int) $matches[2] - 1;
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'CursorPositionX');
             $objWriter->writeAttribute('config:type', 'int');
-            $objWriter->text($colSel);
+            $objWriter->text((string) $colSel);
             $objWriter->endElement();
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'CursorPositionY');
             $objWriter->writeAttribute('config:type', 'int');
-            $objWriter->text($rowSel);
+            $objWriter->text((string) $rowSel);
             $objWriter->endElement();
         }
     }
@@ -126,22 +126,22 @@ private function writeFreezePane(XMLWriter $objWriter, Worksheet $worksheet): vo
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'HorizontalSplitMode');
             $objWriter->writeAttribute('config:type', 'short');
-            $objWriter->text(2);
+            $objWriter->text('2');
             $objWriter->endElement();
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'HorizontalSplitPosition');
             $objWriter->writeAttribute('config:type', 'int');
-            $objWriter->text($columnId - 1);
+            $objWriter->text((string) ($columnId - 1));
             $objWriter->endElement();
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'PositionLeft');
             $objWriter->writeAttribute('config:type', 'short');
-            $objWriter->text(0);
+            $objWriter->text('0');
             $objWriter->endElement();
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'PositionRight');
             $objWriter->writeAttribute('config:type', 'int');
-            $objWriter->text($columnId - 1);
+            $objWriter->text((string) ($columnId - 1));
             $objWriter->endElement();
 
             for ($column = 'A'; $column !== $columnName; ++$column) {
@@ -152,29 +152,29 @@ private function writeFreezePane(XMLWriter $objWriter, Worksheet $worksheet): vo
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'VerticalSplitMode');
             $objWriter->writeAttribute('config:type', 'short');
-            $objWriter->text(2);
+            $objWriter->text('2');
             $objWriter->endElement();
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'VerticalSplitPosition');
             $objWriter->writeAttribute('config:type', 'int');
-            $objWriter->text($row - 1);
+            $objWriter->text((string) ($row - 1));
             $objWriter->endElement();
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'PositionTop');
             $objWriter->writeAttribute('config:type', 'short');
-            $objWriter->text(0);
+            $objWriter->text('0');
             $objWriter->endElement();
             $objWriter->startElement('config:config-item');
             $objWriter->writeAttribute('config:name', 'PositionBottom');
             $objWriter->writeAttribute('config:type', 'int');
-            $objWriter->text($row - 1);
+            $objWriter->text((string) ($row - 1));
             $objWriter->endElement();
         }
 
         $objWriter->startElement('config:config-item');
         $objWriter->writeAttribute('config:name', 'ActiveSplitRange');
         $objWriter->writeAttribute('config:type', 'short');
-        $objWriter->text(3);
+        $objWriter->text('3');
         $objWriter->endElement();
     }
 }