Skip to content

Commit 2628960

Browse files
authored
Improve Coverage for Sylk (#1514)
* Improve Coverage for Sylk I believe that both BaseReader and Sylk Reader are now 100% covered. Documentation available for this format is sparse. It was always incomplete, and in some cases inaccurate. My goal was to use PhpSpreadsheet to load the test file, save it as Xlsx, and visually compare the two, then add a test loaded with assertions. Cell values and calculated values, and border styles were generally handled pretty well without changes. Other types of styling were not handled so well. I added a few cells to exercise some previously uncovered code. Sylk files must be ASCII. I have deprecated the use of the setEncoding and getEncoding functions, which had no test cases.
1 parent 73379cd commit 2628960

File tree

4 files changed

+493
-253
lines changed

4 files changed

+493
-253
lines changed

samples/templates/SylkTest.slk

+2-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ P;EArial;M200
5252
P;EArial;M200;SI
5353
P;EArial;M200;SBI
5454
P;EArial;M200;SBU
55-
P;EArial;M200;SBIU
55+
P;EArial;M220;SBIU
5656
P;EArial;M200
5757
P;EArial;M200;SI
5858
F;P0;DG0G8;M255
@@ -115,6 +115,7 @@ F;P19;FG0G;X4
115115
C;Y7;X2;K2.34
116116
C;X3;KFALSE
117117
C;Y8;X2;K3.45
118+
C;Y9;X2;K2.34;EMEDIAN(R[-3]C:R[-1]C)
118119
F;Y9;X1
119120
F;X2
120121
F;X3

0 commit comments

Comments
 (0)