Skip to content

Commit 2d1375e

Browse files
oleibmanGianluca Giovinazzo
authored and
Gianluca Giovinazzo
committed
Changes for Scrutinizer
Two changes to fix minor problems reported by Scrutinizer.
1 parent bcf8fb3 commit 2d1375e

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

tests/PhpSpreadsheetTests/DefinedNameTest.php

+4-6
Original file line numberDiff line numberDiff line change
@@ -137,12 +137,10 @@ public function testSetAndGetRange(): void
137137

138138
$namedRange = $this->spreadsheet->getDefinedName('XYZ');
139139
self::assertInstanceOf(NamedRange::class, $namedRange);
140-
if ($namedRange instanceof NamedRange) {
141-
self::assertEquals('A1', $namedRange->getRange());
142-
self::assertEquals('A1', $namedRange->getValue());
143-
$namedRange->setRange('A2');
144-
self::assertEquals('A2', $namedRange->getValue());
145-
}
140+
self::assertEquals('A1', $namedRange->getRange());
141+
self::assertEquals('A1', $namedRange->getValue());
142+
$namedRange->setRange('A2');
143+
self::assertEquals('A2', $namedRange->getValue());
146144
}
147145

148146
public function testChangeWorksheet(): void

tests/PhpSpreadsheetTests/IOFactoryTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,6 @@ public function testCreateReaderNotSpreadsheet(): void
200200
{
201201
$this->expectException(\PhpOffice\PhpSpreadsheet\Reader\Exception::class);
202202
$filename = __FILE__;
203-
$reader = IOFactory::createReaderForFile($filename);
203+
IOFactory::createReaderForFile($filename);
204204
}
205205
}

0 commit comments

Comments
 (0)