Skip to content

Commit 37bb153

Browse files
authored
Merge pull request #4186 from oleibman/issue4182
SUMIFS Does Not Require _xlfn
2 parents 27d7920 + c1ad483 commit 37bb153

File tree

3 files changed

+2
-1
lines changed

3 files changed

+2
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
2828
- Xls Writer Condtional Rules Applied to Whole Rows or Columns. [Issue #3185](https://github.com/PHPOffice/PhpSpreadsheet/issues/3185) [PR #4152](https://github.com/PHPOffice/PhpSpreadsheet/pull/4152)
2929
- Xlsx Writer Duplicate ContentTypes Entry for Background Image. [Issue #4179](https://github.com/PHPOffice/PhpSpreadsheet/issues/4179) [PR #4180](https://github.com/PHPOffice/PhpSpreadsheet/pull/4180)
3030
- Check strictNullComparison outside of loops. [PR #3347](https://github.com/PHPOffice/PhpSpreadsheet/pull/3347)
31+
- SUMIFS Does Not Require xlfn. [Issue #4182](https://github.com/PHPOffice/PhpSpreadsheet/issues/4182) [PR #4186](https://github.com/PHPOffice/PhpSpreadsheet/pull/4186)
3132

3233
## 2024-09-29 - 3.3.0 (no 3.0.\*, 3.1.\*, 3.2.\*)
3334

src/PhpSpreadsheet/Writer/Xlsx/FunctionPrefix.php

-1
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ class FunctionPrefix
130130
. '|ifs'
131131
. '|maxifs'
132132
. '|minifs'
133-
. '|sumifs'
134133
. '|textjoin'
135134
// functions added with Excel 365
136135
. '|anchorarray'

tests/PhpSpreadsheetTests/Writer/Xlsx/FunctionPrefixTest.php

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ public static function functionPrefixProvider(): array
3737
'DAYS/NETWORKDAYS 4' => ['ABS(_xlfn.DAYS(DATE(2023,1,1),TODAY()))', 'ABS(_xlfn.DAYS(DATE(2023,1,1),TODAY()))'],
3838
'DAYS/NETWORKDAYS 5' => ['NETWORKDAYS(DATE(2023,1,1),TODAY(), C:C)', 'NETWORKDAYS(DATE(2023,1,1),TODAY(), C:C)'],
3939
'COUNTIFS reclassified as Legacy' => ['COUNTIFS()', 'COUNTIFS()'],
40+
'SUMIFS reclassified as Legacy' => ['SUMIFS()', 'SUMIFS()'],
4041
];
4142
}
4243
}

0 commit comments

Comments
 (0)