Scrutinizer

Its analysis is wrong, but the "errors" it pointed out are easy to fix.

Author: Owen Leibman

src/PhpSpreadsheet/Reader/Xlsx.php

@@ -148,12 +148,10 @@ private function loadStyleZip(string $filename, string $ns = ''): SimpleXMLEleme
             $pattern = "~ xmlns:([A-Za-z0-9_]+)=\"$ns\"~";
             if (preg_match($pattern, $xml, $matches) === 1) {
                 $pattern = "~ xmlns:${matches[1]}=~";
-                $repl = preg_replace($pattern, ' xmlns=', $xml);
-                if (is_string($repl)) {
-                    $pattern = "~<(/?)${matches[1]}:~";
-                    $repl = preg_replace($pattern, '<$1', $repl);
-                }
-                if (is_string($repl)) {
+                $repl = Worksheet::pregReplace($pattern, ' xmlns=', $xml);
+                $pattern = "~<(/?)${matches[1]}:~";
+                $repl = Worksheet::pregReplace($pattern, '<$1', $repl);
+                if ($repl !== '') {
                     $xml = $repl;
                 }
             }

src/PhpSpreadsheet/Reader/Xlsx/Styles.php

@@ -41,10 +41,20 @@ public function setNamespace(string $namespace): void
         $this->namespace = $namespace;
     }
 
+    /**
+     * Cast SimpleXMLElement to bool to overcome Scrutinizer problem.
+     *
+     * @param mixed $value
+     */
+    private static function castBool($value): bool
+    {
+        return (bool) $value;
+    }
+
     private function getStyleAttributes(SimpleXMLElement $value): SimpleXMLElement
     {
         $attr = null;
-        if ($value) {
+        if (self::castBool($value)) {
             $attr = $value->attributes('');
             if ($attr === null || count($attr) === 0) {
                 $attr = $value->attributes($this->namespace);