Style and phpstan cleanups

Author: MarkBaker

src/PhpSpreadsheet/Calculation/Financial/Dollar.php

@@ -68,7 +68,7 @@ public static function decimal($fractionalDollar = null, $fraction = 0)
             return Functions::DIV0();
         }
 
-        $dollars = ($fractionalDollar < 0) ? ceil($fractionalDollar): floor($fractionalDollar);
+        $dollars = ($fractionalDollar < 0) ? ceil($fractionalDollar) : floor($fractionalDollar);
         $cents = fmod($fractionalDollar, 1.0);
         $cents /= $fraction;
         $cents *= 10 ** ceil(log10($fraction));

src/PhpSpreadsheet/Calculation/TextData.php

@@ -18,7 +18,7 @@ class TextData
      *
      * @param string $character Value
      *
-     * @return string
+     * @return array|string
      */
     public static function CHARACTER($character)
     {
@@ -64,9 +64,9 @@ public static function TRIMSPACES($stringValue = '')
      *
      * @see Use the code() method in the TextData\CharacterConvert class instead
      *
-     * @param string $characters Value
+     * @param array|string $characters Value
      *
-     * @return int|string A string if arguments are invalid
+     * @return array|int|string A string if arguments are invalid
      */
     public static function ASCIICODE($characters)
     {
@@ -234,15 +234,15 @@ public static function STRINGLENGTH($value = '')
     /**
      * LOWERCASE.
      *
-     * Converts a string value to upper case.
+     * Converts a string value to lower case.
      *
      * @Deprecated 1.18.0
      *
      * @see Use the lower() method in the TextData\CaseConvert class instead
      *
-     * @param string $mixedCaseString
+     * @param array|string $mixedCaseString
      *
-     * @return string
+     * @return array|string
      */
     public static function LOWERCASE($mixedCaseString)
     {
@@ -260,7 +260,7 @@ public static function LOWERCASE($mixedCaseString)
      *
      * @param string $mixedCaseString
      *
-     * @return string
+     * @return array|string
      */
     public static function UPPERCASE($mixedCaseString)
     {
@@ -270,15 +270,15 @@ public static function UPPERCASE($mixedCaseString)
     /**
      * PROPERCASE.
      *
-     * Converts a string value to upper case.
+     * Converts a string value to proper/title case.
      *
      * @Deprecated 1.18.0
      *
      * @see Use the proper() method in the TextData\CaseConvert class instead
      *
-     * @param string $mixedCaseString
+     * @param array|string $mixedCaseString
      *
-     * @return string
+     * @return array|string
      */
     public static function PROPERCASE($mixedCaseString)
     {

tests/PhpSpreadsheetTests/Calculation/Functions/Financial/DollarDeTest.php

@@ -29,7 +29,7 @@ public function providerDOLLARDE(): array
     {
         return require 'tests/data/Calculation/Financial/DOLLARDE.php';
     }
-    
+
     /**
      * @dataProvider providerDollarDeArray
      */

tests/PhpSpreadsheetTests/Calculation/Functions/TextData/CodeTest.php

@@ -30,7 +30,7 @@ public function providerCODE(): array
     {
         return require 'tests/data/Calculation/TextData/CODE.php';
     }
-    
+
     /**
      * @dataProvider providerCodeArray
      */