Enable array-readiness for more Math/Trig functions

Author: MarkBaker

CHANGELOG.md

@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
 
 ### Added
 
-- Improved support for passing of array arguments to Excel function implementations to return array results (where appropriate). [PR #2562](https://github.com/PHPOffice/PhpSpreadsheet/pull/2562)
+- Improved support for passing of array arguments to Excel function implementations to return array results (where appropriate). [Issue #2551](https://github.com/PHPOffice/PhpSpreadsheet/issues/2551)
 
   This is the first stage in an ongoing process of adding array support to all appropriate function implementations, 
 - Support for the Excel365 Math/Trig SEQUENCE() function [PR #2536](https://github.com/PHPOffice/PhpSpreadsheet/pull/2536)

src/PhpSpreadsheet/Calculation/MathTrig.php

@@ -617,7 +617,7 @@ public static function RAND($min = 0, $max = 0)
      * @param mixed $aValue Number to convert
      * @param mixed $style Number indicating one of five possible forms
      *
-     * @return string Roman numeral, or a string containing an error
+     * @return array|string Roman numeral, or a string containing an error
      */
     public static function ROMAN($aValue, $style = 0)
     {

src/PhpSpreadsheet/Calculation/MathTrig/Roman.php

@@ -2,11 +2,14 @@
 
 namespace PhpOffice\PhpSpreadsheet\Calculation\MathTrig;
 
+use PhpOffice\PhpSpreadsheet\Calculation\ArrayEnabled;
 use PhpOffice\PhpSpreadsheet\Calculation\Exception;
 use PhpOffice\PhpSpreadsheet\Calculation\Functions;
 
 class Roman
 {
+    use ArrayEnabled;
+
     private const VALUES = [
         45 => ['VL'],
         46 => ['VLI'],
@@ -814,12 +817,20 @@ public static function calculateRoman(int $aValue, int $style): string
      * Converts a number to Roman numeral
      *
      * @param mixed $aValue Number to convert
+     *                      Or can be an array of numbers
      * @param mixed $style Number indicating one of five possible forms
+     *                      Or can be an array of styles
      *
-     * @return string Roman numeral, or a string containing an error
+     * @return array|string Roman numeral, or a string containing an error
+     *         If an array of numbers is passed as an argument, then the returned result will also be an array
+     *            with the same dimensions
      */
     public static function evaluate($aValue, $style = 0)
     {
+        if (is_array($aValue) || is_array($style)) {
+            return self::evaluateArrayArguments([self::class, __FUNCTION__], $aValue, $style);
+        }
+
         try {
             $aValue = Helpers::validateNumericNullBool($aValue);
             if (is_bool($style)) {

tests/PhpSpreadsheetTests/Calculation/Functions/MathTrig/RomanTest.php

@@ -2,6 +2,8 @@
 
 namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\MathTrig;
 
+use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
+
 class RomanTest extends AllSetupTeardown
 {
     /**
@@ -24,4 +26,25 @@ public function providerROMAN(): array
     {
         return require 'tests/data/Calculation/MathTrig/ROMAN.php';
     }
+
+    /**
+     * @dataProvider providerRomanArray
+     */
+    public function testRomanArray(array $expectedResult, string $values, string $styles): void
+    {
+        $calculation = Calculation::getInstance();
+
+        $formula = "=ROMAN({$values}, {$styles})";
+        $result = $calculation->_calculateFormulaValue($formula);
+        self::assertEqualsWithDelta($expectedResult, $result, 1.0e-14);
+    }
+
+    public function providerRomanArray(): array
+    {
+        return [
+            'row vector' => [[['XLIX', 'MMXXII', 'CDXCIX']], '{49, 2022, 499}', '0'],
+            'column vector' => [[['XLIX'], ['MMXXII'], ['CDXCIX']], '{49; 2022; 499}', '0'],
+            'matrix' => [[['XLIX', 'MMXXII'], ['LXIV', 'CDXCIX']], '{49, 2022; 64, 499}', '0'],
+        ];
+    }
 }