Modify ABS() function to handle arrays, with appropriate unit tests

Author: MarkBaker

src/PhpSpreadsheet/Calculation/MathTrig/Absolute.php

@@ -6,17 +6,31 @@
 
 class Absolute
 {
+    private static function evaluateArray($numbers)
+    {
+        $result = [];
+        foreach ($numbers as $number) {
+            $result[] = self::evaluate($number);
+        }
+
+        return $result;
+    }
+
     /**
      * ABS.
      *
      * Returns the result of builtin function abs after validating args.
      *
      * @param mixed $number Should be numeric
      *
-     * @return float|int|string Rounded number
+     * @return float|int|string|array Rounded number
      */
     public static function evaluate($number)
     {
+        if (is_array($number)) {
+            return self::evaluateArray($number);
+        }
+
         try {
             $number = Helpers::validateNumericNullBool($number);
         } catch (Exception $e) {

tests/PhpSpreadsheetTests/Calculation/Functions/MathTrig/AbsTest.php

@@ -2,6 +2,8 @@
 
 namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\MathTrig;
 
+use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
+
 class AbsTest extends AllSetupTeardown
 {
     /**
@@ -10,7 +12,7 @@ class AbsTest extends AllSetupTeardown
      * @param mixed $expectedResult
      * @param mixed $number
      */
-    public function testRound($expectedResult, $number = 'omitted'): void
+    public function testAbsolute($expectedResult, $number = 'omitted'): void
     {
         $sheet = $this->getSheet();
         $this->mightHaveException($expectedResult);
@@ -28,4 +30,25 @@ public function providerAbs(): array
     {
         return require 'tests/data/Calculation/MathTrig/ABS.php';
     }
+
+    /**
+     * @dataProvider providerAbsArray
+     */
+    public function testAbsoluteArray(array $expectedResult, string $array): void
+    {
+        $calculation = Calculation::getInstance();
+
+        $formula = "=ABS({$array})";
+        $result = $calculation->_calculateFormulaValue($formula);
+        self::assertSame($expectedResult, $result);
+    }
+
+    public function providerAbsArray(): array
+    {
+        return [
+            'row vector' => [[[1, 0, 1]], '{-1, 0, 1}'],
+            'column vector' => [[[1], [0], [1]], '{-1; 0; 1}'],
+            'matrix' => [[[1, 0], [1, 1]], '{-1, 0; 1, -1}'],
+        ];
+    }
 }