Skip to content

Commit 5dab0a6

Browse files
chrisbobbegnprice
authored andcommitted
msglist: Fix mark-as-read button icon color in dark mode
After sweeping through the message-list screen to implement dark theme (zulip#843), in late July, the Flutter framework merged flutter/flutter#143501, in early August. This made it so our `foregroundColor` no longer controlled the icon color, as promised in the dartdocs of `foregroundColor` and `iconColor`. I opened an issue for Flutter about the inconsistency with the doc: flutter/flutter#154644 and sent a PR to resolve it, by updating the doc (which the author of 143501 had said was the right fix): flutter/flutter#154646 Fixes: zulip#926
1 parent 2dda626 commit 5dab0a6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/widgets/message_list.dart

+1
Original file line numberDiff line numberDiff line change
@@ -758,6 +758,7 @@ class _MarkAsReadWidgetState extends State<MarkAsReadWidget> {
758758
// state is disabled, pressed, etc. We handle those states
759759
// separately, via MarkAsReadAnimation.
760760
foregroundColor: const WidgetStatePropertyAll(Colors.white),
761+
iconColor: const WidgetStatePropertyAll(Colors.white),
761762
backgroundColor: WidgetStatePropertyAll(messageListTheme.unreadMarker),
762763
),
763764
onPressed: _loading ? null : () => _handlePress(context),

0 commit comments

Comments
 (0)