Skip to content

Commit 8809eaf

Browse files
committed
tools/check: Add suite (message content) parser.
Some main benefits of adding both tools/content scripts to tools/check are that you don't need to manage your directories for storing the zuliprc files and corpuses, or specify any command line options for fetching message contents and running the unimplemented features test. The script is intended to be run manually, not as a part of the CI, because it is very slow, and it relies on some out of tree files like API configs (zuliprc files) and big dumps of chat history. Fixes: zulip#190 Signed-off-by: Zixuan James Li <[email protected]>
1 parent 40e26cb commit 8809eaf

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

.gitignore

+4
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,7 @@ app.*.map.json
5353

5454
# Old scaffolding hack
5555
lib/credential_fixture.dart
56+
57+
# Directories used by `tools/check parser`
58+
.corpuses
59+
.api_configs

tools/content/check-features

Whitespace-only changes.

tools/content/fetch_messages.dart

+4
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ import 'model.dart';
2121
/// Because message IDs are only unique within a single server, the script
2222
/// names corpuses from each server differently (if --corpus-dir is specified).
2323
///
24+
/// This script is meant to be run via `tools/check parser`.
25+
///
26+
/// For more help, run `tools/content/fetch_message.dart --help`.
27+
///
2428
/// See tools/content/unimplemented_features_test.dart for more details.
2529
void main(List<String> args) async {
2630
final argParser = ArgParser();

tools/content/unimplemented_features_test.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ import 'model.dart';
1616
/// Check if there are unimplemented features from the given corpuses of HTML
1717
/// contents from Zulip messages.
1818
///
19-
/// This test is meant to be manually run.
19+
/// This test is meant to be run via `tools/check parser`.
2020
///
21-
/// To run it, use:
21+
/// To run it directly, use:
2222
///
2323
/// flutter test tools/content --dart-define=corpusDir=path/to/corpusDir
2424
///

0 commit comments

Comments
 (0)