Skip to content

Commit bea356a

Browse files
committed
perf[Style]: optimize the sidebar style to make it better to set (#1568)
1 parent ce35a6f commit bea356a

File tree

2 files changed

+41
-17
lines changed

2 files changed

+41
-17
lines changed

src/styles/sidebar.scss

+28-11
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,26 @@
5858
width: 100% !important;
5959
}
6060

61+
// menu hover
62+
.submenu-title-noDropdown,
63+
.el-submenu__title {
64+
&:hover {
65+
background-color: $menuHover !important;
66+
}
67+
}
68+
6169
.is-active>.el-submenu__title {
62-
color: #f4f4f5 !important;
70+
color: $subMenuActiveText !important;
71+
}
72+
73+
& .nest-menu .el-submenu>.el-submenu__title,
74+
& .el-submenu .el-menu-item {
75+
min-width: $sideBarWidth !important;
76+
background-color: $subMenuBg !important;
77+
78+
&:hover {
79+
background-color: $subMenuHover !important;
80+
}
6381
}
6482
}
6583

@@ -108,16 +126,6 @@
108126
}
109127
}
110128

111-
.sidebar-container .nest-menu .el-submenu>.el-submenu__title,
112-
.sidebar-container .el-submenu .el-menu-item {
113-
min-width: $sideBarWidth !important;
114-
background-color: $subMenuBg !important;
115-
116-
&:hover {
117-
background-color: $menuHover !important;
118-
}
119-
}
120-
121129
.el-menu--collapse .el-menu .el-submenu {
122130
min-width: $sideBarWidth !important;
123131
}
@@ -150,10 +158,19 @@
150158
}
151159
}
152160

161+
// when menu collapsed
153162
.el-menu--vertical {
154163
&>.el-menu {
155164
.svg-icon {
156165
margin-right: 16px;
157166
}
158167
}
168+
169+
.nest-menu .el-submenu>.el-submenu__title,
170+
.el-menu-item {
171+
&:hover {
172+
// You can use $subMenuHover
173+
background-color: $menuHover !important;
174+
}
175+
}
159176
}

src/styles/variables.scss

+13-6
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,26 @@ $yellow:#FEC171;
99
$panGreen: #30B08F;
1010

1111
//sidebar
12-
$menuBg:#304156;
13-
$subMenuBg:#1f2d3d;
14-
$menuHover:#001528;
1512
$menuText:#bfcbd9;
1613
$menuActiveText:#409EFF;
14+
$subMenuActiveText:#f4f4f5; //https://github.com/ElemeFE/element/issues/12951
15+
16+
$menuBg:#304156;
17+
$menuHover:#263445;
18+
19+
$subMenuBg:#1f2d3d;
20+
$subMenuHover:#001528;
21+
1722
$sideBarWidth: 180px;
1823

1924
// the :export directive is the magic sauce for webpack
2025
:export {
26+
menuText: $menuText;
27+
menuActiveText: $menuActiveText;
28+
subMenuActiveText: $subMenuActiveText;
2129
menuBg: $menuBg;
22-
subMenuBg: $subMenuBg;
2330
menuHover: $menuHover;
24-
menuText:$menuText;
25-
menuActiveText:$menuActiveText;
31+
subMenuBg: $subMenuBg;
32+
subMenuHover: $subMenuHover;
2633
sideBarWidth: $sideBarWidth;
2734
}

0 commit comments

Comments
 (0)