Skip to content

在换肤功能中，如果点击清空颜色，但是没有再去选择颜色，下次换肤的时候oldVal为空，这样就会导致报错 #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LelandACM opened this issue Jan 11, 2019 · 4 comments
Closed

在换肤功能中，如果点击清空颜色，但是没有再去选择颜色，下次换肤的时候oldVal为空，这样就会导致报错 #1516

LelandACM opened this issue Jan 11, 2019 · 4 comments

Comments

@LelandACM
Copy link

Error in callback for watcher "theme": "TypeError: Cannot read property 'replace' of null"
需要将清空按钮禁用或者 添加oldVal、val是否为空的判断
@LelandACM
Copy link
Author

换肤成功后的那个图标本身没有变，其他的页面的控件颜色是变化了，其实是可以将theme的值用 vuex 的state管理起来，像改变控件大小的那个size字段一样

@PanJiaChen
Copy link
Owner

第一个问题：如果点击清空颜色，但是没有再去选择颜色 怎么清空颜色？没有这按钮啊。

@LelandACM
Copy link
Author

image
el-color-picker 自带的clear按钮

@PanJiaChen PanJiaChen mentioned this issue Jan 14, 2019
Merged
@PanJiaChen
Copy link
Owner

Fixed in #1517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PanJiaChen @LelandACM