fix broken liquid physics during structure placement

In a world without any block transformer registered the
physics of the water/lava wouldn't tick further and would stay
static. This can be seen easily with the fountain in the stronghold.

Author: Lulu13022002

paper-server/patches/sources/net/minecraft/world/level/levelgen/structure/StructurePiece.java.patch

@@ -5,7 +5,7 @@
 
                  level.setBlock(worldPos, blockstate, 2);
 +                // CraftBukkit start - fluid handling is already done if we have a transformer generator access
-+                if (level instanceof org.bukkit.craftbukkit.util.TransformerGeneratorAccess) {
++                if (level instanceof org.bukkit.craftbukkit.util.TransformerGeneratorAccess transformerAccess && transformerAccess.canTransformBlocks()) {
 +                    return;
 +                }
 +                // CraftBukkit end
@@ -18,10 +18,10 @@
 
 +    // CraftBukkit start
 +    protected boolean placeCraftBlockEntity(ServerLevelAccessor levelAccessor, BlockPos pos, org.bukkit.craftbukkit.block.CraftBlockEntityState<?> craftBlockEntityState, int flags) {
-+        // todo use place for regular flow and fix liquid physics on placement
-+        if (levelAccessor instanceof org.bukkit.craftbukkit.util.TransformerGeneratorAccess transformerAccess) {
++        if (levelAccessor instanceof org.bukkit.craftbukkit.util.TransformerGeneratorAccess transformerAccess && transformerAccess.canTransformBlocks()) {
 +            return transformerAccess.setCraftBlock(pos, craftBlockEntityState, flags);
 +        }
++
 +        boolean result = levelAccessor.setBlock(pos, craftBlockEntityState.getHandle(), flags);
 +        BlockEntity blockEntity = levelAccessor.getBlockEntity(pos);
 +        if (blockEntity != null) {
@@ -42,7 +42,7 @@
 +        net.minecraft.world.level.block.entity.BlockEntity blockEntity = levelAccessor.getBlockEntity(pos);
 +        if (blockEntity instanceof net.minecraft.world.level.block.entity.RandomizableContainerBlockEntity lootContainerBlockEntity) {
 +            lootContainerBlockEntity.setLootTable(lootTable, randomSource.nextLong());
-+            if (levelAccessor instanceof org.bukkit.craftbukkit.util.TransformerGeneratorAccess transformerAccess) {
++            if (levelAccessor instanceof org.bukkit.craftbukkit.util.TransformerGeneratorAccess transformerAccess && transformerAccess.canTransformBlocks()) {
 +                transformerAccess.setCraftBlock(pos, (org.bukkit.craftbukkit.block.CraftBlockState) org.bukkit.craftbukkit.block.CraftBlockStates.getBlockState(levelAccessor, pos, blockEntity.getBlockState(), lootContainerBlockEntity.saveWithFullMetadata(levelAccessor.registryAccess())), 3);
 +            }
 +        }

paper-server/patches/sources/net/minecraft/world/level/levelgen/structure/structures/DesertPyramidStructure.java.patch

@@ -1,11 +1,12 @@
 --- a/net/minecraft/world/level/levelgen/structure/structures/DesertPyramidStructure.java
 +++ b/net/minecraft/world/level/levelgen/structure/structures/DesertPyramidStructure.java
-@@ -65,6 +_,15 @@
+@@ -65,6 +_,16 @@
 
      private static void placeSuspiciousSand(BoundingBox boundingBox, WorldGenLevel worldGenLevel, BlockPos pos) {
          if (boundingBox.isInside(pos)) {
 +            // CraftBukkit start
-+            if (worldGenLevel instanceof org.bukkit.craftbukkit.util.TransformerGeneratorAccess transformerAccess) {
++            if (worldGenLevel instanceof org.bukkit.craftbukkit.util.TransformerGeneratorAccess transformerAccess && transformerAccess.canTransformBlocks()) {
++                // todo never called cause it's called in afterPlace after the whole capture logic
 +                org.bukkit.craftbukkit.block.CraftBrushableBlock brushableState = (org.bukkit.craftbukkit.block.CraftBrushableBlock) org.bukkit.craftbukkit.block.CraftBlockStates.getBlockState(worldGenLevel, pos, Blocks.SUSPICIOUS_SAND.defaultBlockState(), null);
 +                brushableState.setLootTable(org.bukkit.craftbukkit.CraftLootTable.minecraftToBukkit(BuiltInLootTables.DESERT_PYRAMID_ARCHAEOLOGY));
 +                brushableState.setSeed(pos.asLong());

paper-server/src/main/java/org/bukkit/craftbukkit/util/CraftStructureTransformer.java

@@ -103,10 +103,6 @@ public boolean canTransformBlocks() {
     }
 
     public CraftBlockState transformCraftState(CraftBlockState originalState) {
-        BlockTransformer[] transformers = this.blockTransformers;
-        if (transformers == null || transformers.length == 0) {
-            return originalState;
-        }
         CraftLimitedRegion region = this.limitedRegion;
         if (region == null) {
             return originalState;
@@ -115,7 +111,7 @@ public CraftBlockState transformCraftState(CraftBlockState originalState) {
         BlockPos position = originalState.getPosition();
         BlockState blockState = originalState.copy();
         CraftTransformationState transformationState = new CraftTransformationState(originalState, region.getBlockState(position.getX(), position.getY(), position.getZ()));
-        for (BlockTransformer transformer : transformers) {
+        for (BlockTransformer transformer : this.blockTransformers) {
             blockState = Objects.requireNonNull(transformer.transform(region, position.getX(), position.getY(), position.getZ(), blockState, transformationState), "BlockState can't be null");
             transformationState.destroyCopies();
         }

paper-server/src/main/java/org/bukkit/craftbukkit/util/DelegatedGeneratorAccess.java

@@ -688,8 +688,8 @@ public Player getPlayerByUUID(UUID uuid) {
     }
 
     @Override
-    public boolean setBlock(BlockPos pos, BlockState state, int flags, int maxUpdateDepth) {
-        return this.handle.setBlock(pos, state, flags, maxUpdateDepth);
+    public boolean setBlock(BlockPos pos, BlockState state, int flags, int recursionLeft) {
+        return this.handle.setBlock(pos, state, flags, recursionLeft);
     }
 
     @Override

paper-server/src/main/java/org/bukkit/craftbukkit/util/TransformerGeneratorAccess.java

@@ -24,6 +24,10 @@ public CraftStructureTransformer getStructureTransformer() {
         return this.structureTransformer;
     }
 
+    public boolean canTransformBlocks() {
+        return this.structureTransformer != null && this.structureTransformer.canTransformBlocks();
+    }
+
     @Override
     public boolean addFreshEntity(Entity entity) {
         if (this.structureTransformer != null && !this.structureTransformer.transformEntity(entity)) {
@@ -40,14 +44,12 @@ public boolean addFreshEntity(Entity arg0, SpawnReason arg1) {
         return super.addFreshEntity(arg0, arg1);
     }
 
-    public boolean setCraftBlock(BlockPos position, CraftBlockState craftBlockState, int i, int j) {
-        if (this.structureTransformer != null) {
-            craftBlockState = this.structureTransformer.transformCraftState(craftBlockState);
-        }
+    public boolean setCraftBlock(BlockPos position, CraftBlockState craftBlockState, int flags, int recursionLeft) {
+        craftBlockState = this.structureTransformer.transformCraftState(craftBlockState);
         // This code is based on the method 'net.minecraft.world.level.levelgen.structure.StructurePiece#placeBlock'
         // It ensures that any kind of block is updated correctly upon placing it
         BlockState snapshot = craftBlockState.getHandle();
-        boolean result = super.setBlock(position, snapshot, i, j);
+        boolean result = super.setBlock(position, snapshot, flags, recursionLeft);
         FluidState fluidState = this.getFluidState(position);
         if (!fluidState.isEmpty()) {
             this.scheduleTick(position, fluidState.getType(), 0);
@@ -67,11 +69,11 @@ public boolean setCraftBlock(BlockPos pos, CraftBlockState craftBlockState, int
     }
 
     @Override
-    public boolean setBlock(BlockPos pos, BlockState state, int flags, int maxUpdateDepth) {
-        if (this.structureTransformer == null || !this.structureTransformer.canTransformBlocks()) {
-            return super.setBlock(pos, state, flags, maxUpdateDepth);
+    public boolean setBlock(BlockPos pos, BlockState state, int flags, int recursionLeft) {
+        if (this.canTransformBlocks()) {
+            return this.setCraftBlock(pos, (CraftBlockState) CraftBlockStates.getBlockState(this, pos, state, null), flags, recursionLeft);
         }
-        return this.setCraftBlock(pos, (CraftBlockState) CraftBlockStates.getBlockState(this, pos, state, null), flags, maxUpdateDepth);
+        return super.setBlock(pos, state, flags, recursionLeft);
     }
 
     @Override