Skip to content

Commit 7cc6cb5

Browse files
Check for trailing input in ItemFactory#createItemStack (#12312)
1 parent 72f13f8 commit 7cc6cb5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Diff for: paper-server/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemFactory.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,9 @@ public Color getDefaultLeatherColor() {
153153
@Override
154154
public ItemStack createItemStack(String input) throws IllegalArgumentException {
155155
try {
156-
ItemParser.ItemResult arg = new ItemParser(MinecraftServer.getDefaultRegistryAccess()).parse(new StringReader(input));
156+
StringReader reader = new StringReader(input);
157+
ItemParser.ItemResult arg = new ItemParser(MinecraftServer.getDefaultRegistryAccess()).parse(reader);
158+
Preconditions.checkArgument(!reader.canRead(), "Trailing input found when parsing ItemStack: %s", input);
157159

158160
Item item = arg.item().value();
159161
net.minecraft.world.item.ItemStack nmsItemStack = new net.minecraft.world.item.ItemStack(item);

0 commit comments

Comments
 (0)