Do not mark plugin tickets as forced; keep correct ticket types

Plugin tickets being marked as forced will mess up the forceload
command.

CHUNK_LOAD and FUTURE_AWAIT are the only tickets that should be
preserved on shutdown - logic that is waiting on these to finish
loading is not capable of handling a failure to load.
The logic in general is also not capable of handling the removal
of the ticket identifier in 1.21.5. It is possible to fix these
shortcomings but Moonrise will resolve them, so why bother.

Author: Spottedleaf

paper-server/patches/sources/net/minecraft/server/level/TicketType.java.patch

@@ -6,9 +6,9 @@
      public static final TicketType UNKNOWN = register("unknown", 1L, false, TicketType.TicketUse.LOADING);
 +    public static final TicketType PLUGIN = register("plugin", 0L, false, TicketType.TicketUse.LOADING_AND_SIMULATION); // CraftBukkit
 +    public static final TicketType POST_TELEPORT = register("post_teleport", 5L, false, TicketType.TicketUse.LOADING_AND_SIMULATION); // Paper
-+    public static final TicketType PLUGIN_TICKET = register("plugin_ticket", 0L, false, TicketType.TicketUse.LOADING_AND_SIMULATION); // Paper
-+    public static final TicketType FUTURE_AWAIT = register("future_await", 0L, false, TicketType.TicketUse.LOADING_AND_SIMULATION); // Paper
-+    public static final TicketType CHUNK_LOAD = TicketType.register("chunk_load", TicketType.NO_TIMEOUT, false, TicketType.TicketUse.LOADING); // Paper - moonrise // TODO maybe move to moonrise
++    public static final TicketType PLUGIN_TICKET = register("plugin_ticket", TicketType.NO_TIMEOUT, false, TicketType.TicketUse.LOADING_AND_SIMULATION); // Paper
++    public static final TicketType FUTURE_AWAIT = register("future_await", TicketType.NO_TIMEOUT, false, TicketType.TicketUse.LOADING_AND_SIMULATION); // Paper
++    public static final TicketType CHUNK_LOAD = register("chunk_load", TicketType.NO_TIMEOUT, false, TicketType.TicketUse.LOADING); // Paper - moonrise
 
      public static TicketType register(String name, long timeout, boolean persist, TicketType.TicketUse use) {
          return Registry.register(BuiltInRegistries.TICKET_TYPE, name, new TicketType(timeout, persist, use));

paper-server/patches/sources/net/minecraft/world/level/TicketStorage.java.patch

@@ -1,51 +1,15 @@
 --- a/net/minecraft/world/level/TicketStorage.java
 +++ b/net/minecraft/world/level/TicketStorage.java
-@@ -152,7 +_,7 @@
-             this.loadingChunkUpdatedListener.update(chunkPos, ticket.getTicketLevel(), true);
-         }
- 
--        if (ticket.getType().equals(TicketType.FORCED)) {
-+        if (isForced(ticket.getType())) { // Paper
-             this.chunksWithForcedTickets.add(chunkPos);
-         }
- 
-@@ -235,7 +_,7 @@
-                     this.loadingChunkUpdatedListener.update(chunkPos, getTicketLevelAt(list, false), false);
-                 }
- 
--                if (ticket.getType().equals(TicketType.FORCED)) {
-+                if (isForced(ticket.getType())) { // Paper
-                     this.updateForcedChunks();
-                 }
- 
-@@ -246,7 +_,7 @@
-     }
- 
-     private void updateForcedChunks() {
--        this.chunksWithForcedTickets = this.getAllChunksWithTicketThat(ticket -> ticket.getType().equals(TicketType.FORCED));
-+        this.chunksWithForcedTickets = this.getAllChunksWithTicketThat(ticket -> isForced(ticket.getType())); // Paper
-     }
- 
-     public String getTicketDebugString(long chunkPos, boolean requireSimulation) {
 @@ -264,7 +_,7 @@
      }
 
      public void deactivateTicketsOnClosing() {
 -        this.removeTicketIf(ticket -> ticket.getType() != TicketType.UNKNOWN, this.deactivatedTickets);
-+        this.removeTicketIf(ticket -> doNotPreserve(ticket.getType()), this.deactivatedTickets); // Paper
++        this.removeTicketIf(ticket -> ticket.getType() != TicketType.UNKNOWN && ticket.getType() != TicketType.CHUNK_LOAD && ticket.getType() != TicketType.FUTURE_AWAIT, this.deactivatedTickets);
      }
 
      public void removeTicketIf(Predicate<Ticket> predicate, @Nullable Long2ObjectOpenHashMap<List<Ticket>> tickets) {
-@@ -294,7 +_,7 @@
-                         flag1 = true;
-                     }
- 
--                    if (ticket.getType().equals(TicketType.FORCED)) {
-+                    if (isForced(ticket.getType())) { // Paper
-                         flag = true;
-                     }
-                 }
-@@ -369,4 +_,27 @@
+@@ -369,4 +_,19 @@
      public interface ChunkUpdated {
          void update(long chunkPos, int i, boolean ticketLevel);
      }
@@ -63,13 +27,5 @@
 +    public void removeAllPluginRegionTickets(TicketType ticketType, int ticketLevel, org.bukkit.plugin.Plugin ticketIdentifier) {
 +        removeTicketIf(ticket -> ticket.getType() == ticketType && ticket.getTicketLevel() == ticketLevel && ticket.key == ticketIdentifier, null);
 +    }
-+
-+    private boolean isForced(TicketType type) {
-+        return type == TicketType.FORCED || type == TicketType.PLUGIN_TICKET;
-+    }
-+
-+    private boolean doNotPreserve(TicketType type) {
-+        return type != TicketType.UNKNOWN && type != TicketType.POST_TELEPORT && type != TicketType.FUTURE_AWAIT; // Add additional tickets to preserve
-+    }
 +    // Paper end
  }