[docs] Edits on new Styles docs #503
Conversation
I added a brief intro to shadow DOM scoping, sections on static styles, inline styles and external styles, and tried to clarify the organization around what elements styles apply to: host, shadow root, or slotted. Not sure if the top-level headings are right though
Co-Authored-By: justinfagnani <[email protected]>
ghost
requested a review
from 
Co-Authored-By: katejeffreys <[email protected]>
Co-Authored-By: katejeffreys <[email protected]>
Co-Authored-By: katejeffreys <[email protected]>
…-element into styles-doc-update-kj
ghost
mentioned this pull request
ghost
changed the title
|
@katejeffreys I don't see most of the changes anymore. Oops, my fault. |
docs/_guide/styles.md
Outdated
|
|
||
| In this section: | ||
|
|
||
| * [Write CSS styles for a host element](#host-styles). The host element is your component. It is called the "host" because it hosts shadow DOM. You can style the element itself with the special CSS selectors `:host` and `:host()`. |
There was a problem hiding this comment.
description duplicates the into to this page
docs/_guide/styles.md
Outdated
|
|
||
| * [Write CSS styles for a host element](#host-styles). The host element is your component. It is called the "host" because it hosts shadow DOM. You can style the element itself with the special CSS selectors `:host` and `:host()`. | ||
| * [Write CSS styles for elements in shadow DOM](#shadow-dom-styles). | ||
| * [Write CSS styles for slotted children](#slotted-styles). Light DOM children of your host element can be rendered in shadow DOM via the `slot` element. You can style slotted content with the `::slotted()` CSS selector. |
There was a problem hiding this comment.
Maybe leave off the second sentence, and change the first to just define "slotted children", like:
Slotted elements are light DOM children of the host that are rendered into a shadow root with the
<slot>element.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
@jbingham pls check your CLA |
|
@katejeffreys we can go ahead without @jbingham's CLA. He's either not in the right orgs, or the CLA bot sometimes just messes up on any PR with multiple authors. |
|
I checked any my jbingham account is linked to my Google email address.
I've been doing this for years, so not sure what's up
…On Mon, Feb 4, 2019 at 4:29 PM Justin Fagnani ***@***.***> wrote:
@katejeffreys <https://github.com/katejeffreys> we can go ahead without
@jbingham <https://github.com/jbingham>'s CLA. He's either not in the
right orgs, or the CLA bot sometimes just messes up on any PR with multiple
authors.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#503 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAiXqWeICWIyZP66y-BxZJ0kjWc8boeiks5vKNB-gaJpZM4abNft>
.
|
|
Sorry @jbingham, idk what happened there, dont' think it was you |
|
|
||
| If you don't want to use custom properties, you can define per-instance styles in a `<style>` element inside shadow DOM. See the section on [Defining your styles in a style element](#styleelement) for more information. | ||
|
|
||
| </div> |
https://polymer-lit-element-staging.appspot.com/