Skip to content

Windows should not be a plural noun #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilasuit opened this issue Oct 27, 2021 · 1 comment
Open

Windows should not be a plural noun #1736

kilasuit opened this issue Oct 27, 2021 · 1 comment

Comments

@kilasuit
Copy link
Contributor

kilasuit commented Oct 27, 2021

Before submitting a bug report:

  • Make sure you are able to repro it on the latest released version
  • Perform a quick search for existing issues to check if this bug has already been reported

Steps to reproduce

See this tweet https://twitter.com/FrankLesniak/status/1453189852032344064?s=20

function Test-Windows {
dostuff
}

Expected behavior

PSUseSingularNouns warning is not thrown when noun finishes with Windows

Actual behavior

PSUseSingularNouns warning thrown

If an unexpected error was thrown then please report the full error details using e.g. $error[0] | Select-Object *

Environment data

Name                           Value
----                           -----
PSVersion                      7.2.0-preview.10
PSEdition                      Core
GitCommitId                    7.2.0-preview.10
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0



1.18.3 - Doesn't throw
1.20.0 - Does throw
@ghost ghost added the Needs: Triage 🔍 label Oct 27, 2021
@rjmholt
Copy link
Contributor

rjmholt commented Oct 27, 2021

Consider adding it here:

private readonly string[] nounAllowList =
{
"Data"
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants