Skip to content

Commit 7fa1abc

Browse files
authored
Remove Secret Scan stage from PR ci, as it's already enabled (#818)
* remove Secret Scan stage from PR ci, as it's already enabled * change package arg to reflect package name change (alpine to musl) * update meta.json also for alpine316 and alpine317
1 parent d6de8c9 commit 7fa1abc

File tree

5 files changed

+4
-29
lines changed

5 files changed

+4
-29
lines changed

Diff for: release/7-2/alpine316/docker/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ FROM ${hostRegistry}/alpine:3.16 AS installer-env
77

88
# Define Args for the needed to add the package
99
ARG PS_VERSION=7.3.0-preview.8
10-
ARG PS_PACKAGE=powershell-${PS_VERSION}-linux-alpine-x64.tar.gz
10+
ARG PS_PACKAGE=powershell-${PS_VERSION}-linux-musl-x64.tar.gz
1111
ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v${PS_VERSION}/${PS_PACKAGE}
1212
ARG PS_INSTALL_VERSION=7-preview
1313

Diff for: release/7-2/alpine316/meta.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"IsLinux" : true,
33
"UseLinuxVersion": false,
4-
"PackageFormat": "powershell-${PS_VERSION}-linux-alpine-x64.tar.gz",
4+
"PackageFormat": "powershell-${PS_VERSION}-linux-musl-x64.tar.gz",
55
"osVersion": "Alpine 3.16",
66
"shortDistroName": "alpine",
77
"shortTags": [

Diff for: release/7-2/alpine317/docker/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ FROM ${hostRegistry}/alpine:3.17 AS installer-env
77

88
# Define Args for the needed to add the package
99
ARG PS_VERSION=7.3.0-preview.8
10-
ARG PS_PACKAGE=powershell-${PS_VERSION}-linux-alpine-x64.tar.gz
10+
ARG PS_PACKAGE=powershell-${PS_VERSION}-linux-musl-x64.tar.gz
1111
ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v${PS_VERSION}/${PS_PACKAGE}
1212
ARG PS_INSTALL_VERSION=7-preview
1313

Diff for: release/7-2/alpine317/meta.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"IsLinux" : true,
33
"UseLinuxVersion": false,
4-
"PackageFormat": "powershell-${PS_VERSION}-linux-alpine-x64.tar.gz",
4+
"PackageFormat": "powershell-${PS_VERSION}-linux-musl-x64.tar.gz",
55
"osVersion": "Alpine 3.17",
66
"shortDistroName": "alpine",
77
"shortTags": [

Diff for: vsts-ci.yml

-25
Original file line numberDiff line numberDiff line change
@@ -58,28 +58,3 @@ stages:
5858
displayName: Check for Duplicate Tags
5959
condition: succeededOrFailed()
6060
61-
- stage: Secret_Scan
62-
displayName: Secret Scan
63-
dependsOn: []
64-
jobs:
65-
- job: Secret_Scan
66-
pool:
67-
vmImage: windows-latest
68-
displayName: Secret Scan
69-
70-
steps:
71-
- task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@2
72-
displayName: 'Scan for secrets'
73-
inputs:
74-
debugMode: false
75-
toolMajorVersion: V2
76-
77-
- task: securedevelopmentteam.vss-secure-development-tools.build-task-publishsecurityanalysislogs.PublishSecurityAnalysisLogs@2
78-
displayName: 'Publish Secret Scan Logs to Build Artifacts'
79-
continueOnError: true
80-
81-
- task: securedevelopmentteam.vss-secure-development-tools.build-task-postanalysis.PostAnalysis@1
82-
displayName: 'Check for Failures'
83-
inputs:
84-
CredScan: true
85-
ToolLogsNotFoundAction: Error

0 commit comments

Comments
 (0)