Place copyright notifications in module

Update to use variables instead of duplicated strings
Support authtoken since it's pretty easy to hit Github limits on API call
Use Invoke-RestMethod consistently (rather than Invoke-WebRequest in places)

Author: JamesWTruher

tools/Modules/RFC/RFC.psd1

@@ -24,56 +24,28 @@ GUID = 'e05ba184-7bd8-4a16-9f41-93d7c7bd4ee6'
 Author = 'jimtru'
 
 # Company or vendor of this module
-CompanyName = 'Unknown'
+CompanyName = 'Microsoft'
 
 # Copyright statement for this module
-Copyright = '(c) jimtru. All rights reserved.'
+Copyright = 'Copyright (c) Microsoft Corporation. All rights reserved.'
 
 # Description of the functionality provided by this module
 # Description = ''
 
-# Minimum version of the PowerShell engine required by this module
-# PowerShellVersion = ''
-
-# Name of the PowerShell host required by this module
-# PowerShellHostName = ''
-
-# Minimum version of the PowerShell host required by this module
-# PowerShellHostVersion = ''
-
-# Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
-# DotNetFrameworkVersion = ''
-
-# Minimum version of the common language runtime (CLR) required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
-# CLRVersion = ''
-
-# Processor architecture (None, X86, Amd64) required by this module
-# ProcessorArchitecture = ''
-
-# Modules that must be imported into the global environment prior to importing this module
-# RequiredModules = @()
-
-# Assemblies that must be loaded prior to importing this module
-# RequiredAssemblies = @()
-
-# Script files (.ps1) that are run in the caller's environment prior to importing this module.
-# ScriptsToProcess = @()
 
 # Type files (.ps1xml) to be loaded when importing this module
 TypesToProcess = @('RFC.Types.ps1xml')
 
 # Format files (.ps1xml) to be loaded when importing this module
 FormatsToProcess = @('RFC.Formats.ps1xml')
 
-# Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
-# NestedModules = @()
-
 # Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
 FunctionsToExport = @(
     'Get-MaxRFCNumber', 'Get-MaxRFC', 'Get-PullRFCNumber', 'Get-RFCPullRequest',
     'Get-HighestPullRFCNumber', 'Get-NextRFCNumber', 'Get-NextRFCFileName', 'Get-GitFork',
     'Get-GitBranchesFromFork', 'Get-GitTreeFromBranch', 'Get-LastCommit', 'Get-RepoFileList',
-    'Get-PR'
+    'Get-PR',
+    "Set-Header", "Get-Header", "Remove-Header"
     )
 
 # Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
@@ -85,45 +57,15 @@ VariablesToExport = '*'
 # Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
 AliasesToExport = @()
 
-# DSC resources to export from this module
-# DscResourcesToExport = @()
-
-# List of all modules packaged with this module
-# ModuleList = @()
-
-# List of all files packaged with this module
-# FileList = @()
-
 # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
 PrivateData = @{
 
     PSData = @{
 
-        # Tags applied to this module. These help with module discovery in online galleries.
-        # Tags = @()
-
-        # A URL to the license for this module.
-        # LicenseUri = ''
-
-        # A URL to the main website for this project.
-        # ProjectUri = ''
-
-        # A URL to an icon representing this module.
-        # IconUri = ''
-
-        # ReleaseNotes of this module
-        # ReleaseNotes = ''
-
     } # End of PSData hashtable
 
 } # End of PrivateData hashtable
 
-# HelpInfo URI of this module
-# HelpInfoURI = ''
-
-# Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix.
-# DefaultCommandPrefix = ''
-
 }
 
 

tools/Modules/RFC/RFC.psm1

@@ -1,4 +1,27 @@
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
 $script:repoBase = "https://api.github.com/repos"
+$script:repositoryOwner = "PowerShell"
+$script:repositoryName  = "PowerShell"
+$script:Headers = @{ }
+
+$PSDefaultParameterValues['Invoke-RestMethod:Headers'] = $script:Headers
+
+function Set-Header {
+    param ( $token )
+    $script:Headers = @{ Authorization = "Bearer $token" }
+    $PSDefaultParameterValues['Invoke-RestMethod:Headers'] = $script:Headers
+}
+
+function Remove-Header {
+    if ( $PSDefaultParameterValues['Invoke-RestMethod:Headers'] ) {
+         $PSDefaultParameterValues.Remove("Invoke-RestMethod:Headers")
+    }
+}
+
+function Get-Header {
+    $PSDefaultParameterValues['Invoke-RestMethod:Headers']
+}
 
 <#
 .SYNOPSIS
@@ -16,9 +39,9 @@ PS> get-maxrfcnumber
 #>
 
 function Get-MaxRFCNumber {
-    $repoOwner = "PowerShell"
+    # specify a new repoName, since it's specific to RFCs
     $repoName = "PowerShell-RFC"
-    $repoFiles = Get-RepoFileList -repoOwner $repoOwner -repoName $repoName
+    $repoFiles = Get-RepoFileList -repoOwner $script:repositoryOwner -repoName $repoName
     $pattern = "RFC(?<number>\d\d\d\d)-"
     $numbers = $repoFiles.Where({$_.path -cmatch $pattern}).Foreach({if ( $_ -match $pattern ) { [int]($matches.number)}}) | Sort-Object
     $numbers[-1]
@@ -44,8 +67,8 @@ General notes
 function Get-MaxRFC {
     $maxNumber = Get-MaxRFCNumber
     $rfcPattern = "RFC{0:0000}" -f $maxNumber
-    $RFC = (Get-RepoFileList -repoOwner PowerShell -repoName PowerShell-RFC).Where({$_.path -cmatch $rfcPattern})
-    $RFC | Add-Member -TypeName RepoFile -PassThru -MemberType NoteProperty -Name file_url -Value ("https://github.com/PowerShell/PowerShell-RFC/blob/master/" + $RFC.path)
+    $RFC = (Get-RepoFileList -repoOwner $script:repositoryOwner -repoName PowerShell-RFC).Where({$_.path -cmatch $rfcPattern})
+    $RFC | Add-Member -TypeName RepoFile -PassThru -MemberType NoteProperty -Name file_url -Value ("https://github.com/${script:repositoryOwner}/PowerShell-RFC/blob/master/" + $RFC.path)
 }
 
 # get the RFCs referenced in PRs
@@ -73,12 +96,9 @@ function Get-PullRFCNumber {
     )
 
     $rfcs = [System.Collections.ArrayList]::new()
-    $page = 1
-    do {
-        $st = Invoke-RestMethod "${repoBase}/PowerShell/PowerShell-RFC/pulls?state=${State}&per_page=100&page=${page}"
-        $st.Foreach({ if ( $_.Title -match "RFC(?<num>\d\d\d\d)" ) { $null = $rfcs.Add([int]$matches.num) } })
-        $page++
-    } while ( $st.Count -gt 1 )
+    $url = "${repoBase}/${script:repositoryOwner}/PowerShell-RFC/pulls?state=${State}"
+    $st = Invoke-RestMethod -FollowRelLink $url | Foreach-Object { $_ }
+    $st.Foreach({ if ( $_.Title -match "RFC(?<num>\d\d\d\d)" ) { $null = $rfcs.Add([int]$matches.num) } })
     $rfcs.Sort()
     return $rfcs
 }
@@ -118,20 +138,17 @@ General notes
 
 function Get-PR {
     param (
-        [Parameter()]$repoOwner = "PowerShell",
-        [Parameter()]$repoName = "PowerShell",
+        [Parameter()]$repoOwner = $script:repositoryOwner,
+        [Parameter()]$repoName = $script:repositoryName,
         [ValidateSet("open","closed","all")]
         [Parameter()]$State = "all",
         [Parameter()]$PageCount = [int]::maxvalue
     )
 
-    $page = 1
-    do {
-        $url = "${repoBase}/${repoOwner}/${repoName}/pulls?state=${State}&per_page=100&page=${page}"
-        $st = Invoke-RestMethod $url
-        $st.Foreach({$_.PSObject.TypeNames.Insert(0,"GitPullRequest");$_})
-        $page++
-    } while ( $st.Count -gt 1 -and $page -lt $PageCount + 1)
+    $url = "${repoBase}/${repoOwner}/${repoName}/pulls?state=${State}"
+    # get the data, and unspool the collections returned as a result of -FollowRelLink
+    $st = Invoke-RestMethod -FollowRelLink $url | Foreach-Object { $_ }
+    $st.Foreach({$_.PSObject.TypeNames.Insert(0,"GitPullRequest");$_})
 
 }
 
@@ -165,6 +182,7 @@ function Get-RFCPullRequest {
         [Parameter()]$State = "open"
     )
 
+    # specific to RFC repo
     Get-PR -repoName "PowerShell-RFC" -State $State
 }
 
@@ -234,22 +252,22 @@ pushed_at           html_url
 function Get-GitFork {
     [CmdletBinding(DefaultParameterSetName="owner")]
     param (
-        [Parameter(ParameterSetName="owner")]$repoOwner = "PowerShell", $repoName = "PowerShell" ,
+        [Parameter(ParameterSetName="owner")]$repoOwner = $script:repositoryOwner,
+        [Parameter(ParameterSetName="owner")]$repoName = $script:repositoryName,
         [Parameter(ParameterSetName="fork")]$forkUrl
         )
     if ( ! $forkUrl ) {
         $forkUrl = "${repoBase}/${repoOwner}/${repoName}/forks"
     }
     try {
         # if we have a problem bail
-        $result = Invoke-WebRequest "${forkUrl}?per_page=100"
+        $result = Invoke-RestMethod -FollowRelLink "${forkUrl}" | Foreach-Object { $_ }
     }
     catch {
-        Write-Warning "Could not get data from $forkUrl"
+        Write-Warning "Could not get data from $forkUrl ($_)"
         return
     }
-    $forks = $result.Content | ConvertFrom-Json
-    foreach ( $fork in $forks ) {
+    foreach ( $fork in $result ) {
         if ( $fork.forks -ne 0 ) {
             Get-GitFork -forkUrl $fork.forks_url
         }
@@ -280,7 +298,7 @@ General notes
 function Get-GitBranchesFromFork {
     param ( $Fork )
     $branchurl = $Fork.branches_url -replace "{/branch}$"
-    $branchInfo = (Invoke-WebRequest $branchurl).Content | ConvertFrom-Json
+    $branchInfo = Invoke-RestMethod $branchurl
     $branchInfo.Foreach({$_.psobject.typenames.insert(0,"GitBranchInfo");$_})
 }
 
@@ -307,12 +325,11 @@ General notes
 
 function Get-LastCommit
 {
-    param ( $repoOwner = "PowerShell", $repoName = "PowerShell" )
-    #$d = "{0:YYYY}-{0:MM}-{0:DD}T{0:HH}:{0:mm}:{0:ss}Z" -f [datetime]::now()
+    param ( $repoOwner = $script:repositoryOwner, $repoName = $script:repositoryName )
+
     $repo ="${repoBase}/${repoOwner}/${repoName}/commits"
-    $r = invoke-webrequest $repo
-    $rContent = $r.content | ConvertFrom-Json
-    $lastCommit = $rContent | Sort-Object {$_.commit.committer.date}|Select-Object -Last 1
+    $result = Invoke-RestMethod $repo
+    $lastCommit = $result | Sort-Object {$_.commit.committer.date}|Select-Object -Last 1
     return $lastCommit.sha
 }
 
@@ -347,13 +364,12 @@ General notes
 
 function Get-RepoFileList
 {
-    param ( $commit, $repoOwner = "PowerShell", $repoName = "PowerShell" )
+    param ( $commit, $repoOwner = $script:repositoryOwner, $repoName = $script:repositoryName )
     if ( ! $commit ) {
         $commit = Get-LastCommit -repoOwner $repoOwner -repoName $repoName
     }
     $repo = "${repoBase}/${repoOwner}/${repoName}/git/trees/${commit}?recursive=1"
-    $r = invoke-webrequest $repo
-    $rContent = $r.content | ConvertFrom-Json
+    $rContent = Invoke-RestMethod $repo
     if ( $rContent.truncated ) {
         #Get-RepoFileListFromTree $commit
     }