rob's feedback

Author: TylerLeonhardt

Diff for: src/PowerShellEditorServices/Services/CodeLens/ReferencesCodeLensProvider.cs

@@ -115,9 +115,9 @@ public CodeLens ResolveCodeLens(CodeLens codeLens, ScriptFile scriptFile)
 
                     DocumentUri uri = DocumentUri.From(foundReference.FilePath);
                     // For any vscode-notebook-cell, we need to ignore the backing file on disk.
-                    if (scriptFile.DocumentUri.Scheme == "vscode-notebook-cell" &&
-                        uri.Path == scriptFile.DocumentUri.Path &&
-                        uri.Scheme == "file")
+                    if (uri.Scheme == "file" &&
+                        scriptFile.DocumentUri.Scheme == "vscode-notebook-cell" &&
+                        uri.Path == scriptFile.DocumentUri.Path)
                     {
                         continue;
                     }

Diff for: src/PowerShellEditorServices/Services/TextDocument/ScriptFile.cs

@@ -217,7 +217,10 @@ internal static List<string> GetLinesInternal(string text)
         internal static bool IsUntitledPath(string path)
         {
             Validate.IsNotNull(nameof(path), path);
-            return DocumentUri.From(path).Scheme.ToLower() != Uri.UriSchemeFile;
+            return string.Equals(
+                DocumentUri.From(path).Scheme,
+                Uri.UriSchemeFile,
+                StringComparison.OrdinalIgnoreCase);
         }
 
         /// <summary>