Rename "Provider" to "FeatureProvider"

This name change will help the purpose of this design to be more obvious
and also distinguish it from other PowerShell features that are called
"providers."

Author: daviwil

src/PowerShellEditorServices.Host/CodeLens/CodeLensFeature.cs

@@ -25,8 +25,8 @@ internal class CodeLensFeature : ICodeLenses
              JsonSerializer.Create(
                  Constants.JsonSerializerSettings);
 
-        public IProviderCollection<ICodeLensProvider> Providers { get; } =
-            new ProviderCollection<ICodeLensProvider>();
+        public IFeatureProviderCollection<ICodeLensProvider> Providers { get; } =
+            new FeatureProviderCollection<ICodeLensProvider>();
 
         public CodeLensFeature(
             EditorSession editorSession,

src/PowerShellEditorServices.Host/CodeLens/ReferencesCodeLensProvider.cs

@@ -14,7 +14,7 @@
 
 namespace Microsoft.PowerShell.EditorServices.CodeLenses
 {
-    internal class ReferencesCodeLensProvider : ProviderBase, ICodeLensProvider
+    internal class ReferencesCodeLensProvider : FeatureProviderBase, ICodeLensProvider
     {
         private EditorSession editorSession;
         private IDocumentSymbolProvider symbolProvider;

src/PowerShellEditorServices.Host/Symbols/DocumentSymbolFeature.cs

@@ -21,8 +21,8 @@ internal class DocumentSymbolFeature : IDocumentSymbols
     {
         private EditorSession editorSession;
 
-        public IProviderCollection<IDocumentSymbolProvider> Providers { get; } =
-            new ProviderCollection<IDocumentSymbolProvider>();
+        public IFeatureProviderCollection<IDocumentSymbolProvider> Providers { get; } =
+            new FeatureProviderCollection<IDocumentSymbolProvider>();
 
         public DocumentSymbolFeature(
             EditorSession editorSession,

src/PowerShellEditorServices/CodeLenses/ICodeLensProvider.cs

@@ -14,7 +14,7 @@ namespace Microsoft.PowerShell.EditorServices.CodeLenses
     /// <summary>
     /// Specifies the contract for a Code Lens provider.
     /// </summary>
-    public interface ICodeLensProvider : IProvider
+    public interface ICodeLensProvider : IFeatureProvider
     {
         /// <summary>
         /// Provides a collection of CodeLenses for the given

src/PowerShellEditorServices/CodeLenses/ICodeLenses.cs

@@ -19,7 +19,7 @@ public interface ICodeLenses
         /// Gets the collection of ICodeLensProvider implementations
         /// that are registered with this component.
         /// </summary>
-        IProviderCollection<ICodeLensProvider> Providers { get; }
+        IFeatureProviderCollection<ICodeLensProvider> Providers { get; }
 
         /// <summary>
         /// Provides a collection of CodeLenses for the given

src/PowerShellEditorServices/Providers/ProviderBase.cs renamed to src/PowerShellEditorServices/Providers/FeatureProviderBase.cs

@@ -6,9 +6,9 @@
 namespace Microsoft.PowerShell.EditorServices
 {
     /// <summary>
-    /// Provides a base implementation of IProvider.
+    /// Provides a base implementation of IFeatureProvider.
     /// </summary>
-    public abstract class ProviderBase : IProvider
+    public abstract class FeatureProviderBase : IFeatureProvider
     {
         /// <summary>
         /// Gets the provider class type's FullName as the

src/PowerShellEditorServices/Providers/ProviderCollection.cs renamed to src/PowerShellEditorServices/Providers/FeatureProviderCollection.cs

@@ -10,20 +10,20 @@
 namespace Microsoft.PowerShell.EditorServices
 {
     /// <summary>
-    /// Provides a default implementation of IProviderCollection.
+    /// Provides a default implementation of IFeatureProviderCollection.
     /// </summary>
-    public class ProviderCollection<TProvider> : IProviderCollection<TProvider>
-        where TProvider : IProvider
+    public class FeatureProviderCollection<TProvider> : IFeatureProviderCollection<TProvider>
+        where TProvider : IFeatureProvider
     {
         #region Private Fields
 
         private List<TProvider> providerList = new List<TProvider>();
 
         #endregion
 
-        #region IProviderCollection Implementation
+        #region IFeatureProviderCollection Implementation
 
-        void IProviderCollection<TProvider>.Add(TProvider provider)
+        void IFeatureProviderCollection<TProvider>.Add(TProvider provider)
         {
             if (!this.providerList.Contains(provider))
             {

src/PowerShellEditorServices/Providers/IProvider.cs renamed to src/PowerShellEditorServices/Providers/IFeatureProvider.cs

@@ -8,10 +8,10 @@ namespace Microsoft.PowerShell.EditorServices
     /// <summary>
     /// Defines the contract for a feature provider, particularly for provider identification.
     /// </summary>
-    public interface IProvider
+    public interface IFeatureProvider
     {
         /// <summary>
-        /// Specifies a unique identifier for a provider, typically a
+        /// Specifies a unique identifier for the feature provider, typically a
         /// fully-qualified name like "Microsoft.PowerShell.EditorServices.MyProvider"
         /// </summary>
         string ProviderId { get; }

src/PowerShellEditorServices/Providers/IProviderCollection.cs renamed to src/PowerShellEditorServices/Providers/IFeatureProviderCollection.cs

@@ -10,8 +10,8 @@ namespace Microsoft.PowerShell.EditorServices
     /// <summary>
     /// Defines the contract for a collection of provider implementations.
     /// </summary>
-    public interface IProviderCollection<TProvider> : IEnumerable<TProvider>
-        where TProvider : IProvider
+    public interface IFeatureProviderCollection<TProvider> : IEnumerable<TProvider>
+        where TProvider : IFeatureProvider
     {
         /// <summary>
         /// Adds a provider to the collection.

src/PowerShellEditorServices/Symbols/IDocumentSymbolProvider.cs

@@ -10,7 +10,7 @@ namespace Microsoft.PowerShell.EditorServices.Symbols
     /// <summary>
     /// Specifies the contract for a document symbols provider.
     /// </summary>
-    public interface IDocumentSymbolProvider : IProvider
+    public interface IDocumentSymbolProvider : IFeatureProvider
     {
         /// <summary>
         /// Provides a list of symbols for the given document.

src/PowerShellEditorServices/Symbols/IDocumentSymbols.cs

@@ -17,7 +17,7 @@ public interface IDocumentSymbols
         /// Gets the collection of IDocumentSymbolsProvider implementations
         /// that are registered with this component.
         /// </summary>
-        IProviderCollection<IDocumentSymbolProvider> Providers { get; }
+        IFeatureProviderCollection<IDocumentSymbolProvider> Providers { get; }
 
         /// <summary>
         /// Provides a list of symbols for the given document.

src/PowerShellEditorServices/Symbols/PesterDocumentSymbolProvider.cs

@@ -14,7 +14,7 @@ namespace Microsoft.PowerShell.EditorServices.Symbols
     /// Provides an IDocumentSymbolProvider implementation for
     /// enumerating test symbols in Pester test (tests.ps1) files.
     /// </summary>
-    public class PesterDocumentSymbolProvider : ProviderBase, IDocumentSymbolProvider
+    public class PesterDocumentSymbolProvider : FeatureProviderBase, IDocumentSymbolProvider
     {
         IEnumerable<SymbolReference> IDocumentSymbolProvider.ProvideDocumentSymbols(
             ScriptFile scriptFile)

src/PowerShellEditorServices/Symbols/PsdDocumentSymbolProvider.cs

@@ -13,7 +13,7 @@ namespace Microsoft.PowerShell.EditorServices.Symbols
     /// Provides an IDocumentSymbolProvider implementation for
     /// enumerating symbols in .psd1 files.
     /// </summary>
-    public class PsdDocumentSymbolProvider : ProviderBase, IDocumentSymbolProvider
+    public class PsdDocumentSymbolProvider : FeatureProviderBase, IDocumentSymbolProvider
     {
         IEnumerable<SymbolReference> IDocumentSymbolProvider.ProvideDocumentSymbols(
             ScriptFile scriptFile)

src/PowerShellEditorServices/Symbols/ScriptDocumentSymbolProvider.cs

@@ -13,7 +13,7 @@ namespace Microsoft.PowerShell.EditorServices.Symbols
     /// Provides an IDocumentSymbolProvider implementation for
     /// enumerating symbols in script (.psd1, .psm1) files.
     /// </summary>
-    public class ScriptDocumentSymbolProvider : ProviderBase, IDocumentSymbolProvider
+    public class ScriptDocumentSymbolProvider : FeatureProviderBase, IDocumentSymbolProvider
     {
         private Version powerShellVersion;