Skip to content

Symbol renaming incorrectly changes symbols that start with the original symbol's name #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rs38 opened this issue Jun 21, 2016 · 4 comments
Labels

Comments

@rs38
Copy link

rs38 commented Jun 21, 2016

Currently it (called "change all occurancies") can only find&replace which is not usefull to refactor (as it also changes comments and unrelated similar variables). This is not like rename.refactor e.g. for C#
Example:

$URI= "http://localhost:8080/"
$URI2= "http://Server2"
$IEexe= "C:\Program Files\Internet Explorer\iexplore.exe" 
& $IEexe $URI
& $IEexe $URI2

renaming $URI to $URIOriginal will also change unrelated $URI2

@daviwil
Copy link
Contributor

daviwil commented Jul 7, 2016

Yep, I think there's a bug with the renaming here. We'll get it fixed. Thanks!

@daviwil daviwil added the Issue-Bug A bug to squash. label Jul 7, 2016
@daviwil daviwil changed the title feature request: true refactor.rename Symbol renaming incorrectly changes symbols that start with the original symbol's name Jul 7, 2016
@TylerLeonhardt
Copy link
Member

Interesting. If you highlight just "URI" on line one, I can repro your issue.

However, if you don't highlight anything, renaming works as expected.

@JustinGrote
Copy link
Collaborator

JustinGrote commented Apr 17, 2020

@TylerLeonhardt I can't reproduce, though there is a difference between "clicking" a symbol and "dragging" over the symbol. Dragging will be any characters you select.

Capture

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Apr 17, 2020
@SydneyhSmith SydneyhSmith removed the Needs: Maintainer Attention Maintainer attention needed! label Apr 21, 2020
@SydneyhSmith
Copy link
Collaborator

I think its also important to note that we dont officially support renaming #1440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants