Skip to content

Fix CI by removing Azure Artifacts Feeds #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ jobs:
DOTNET_CLI_TELEMETRY_OPTOUT: true
DOTNET_GENERATE_ASPNET_CERTIFICATE: false
DISPLAY: ':99.0'
defaults:
run:
working-directory: vscode-powershell
steps:
- name: Checkout PowerShellEditorServices
uses: actions/checkout@v4
Expand All @@ -40,24 +37,20 @@ jobs:
uses: actions/setup-dotnet@v4
with:
cache: true
cache-dependency-path: 'PowerShellEditorServices/**/packages.lock.json'
cache-dependency-path: PowerShellEditorServices/**/packages.lock.json
global-json-file: PowerShellEditorServices/global.json
source-url: https://pkgs.dev.azure.com/mscodehub/PowerShellCore/_packaging/PowerShellCore_PublicPackages/nuget/v3/index.json
config-file: PowerShellEditorServices/NuGet.config
env:
NUGET_AUTH_TOKEN: ${{ secrets.AZURE_NUGET_TOKEN }}

- name: Install PSResources
shell: pwsh
run: ./tools/installPSResources.ps1

- name: Deploy generated NuGet configuration
- name: Remove Azure Artifact Feed configurations
shell: pwsh
run: Copy-Item ../../nuget.config ../PowerShellEditorServices/NuGet.config
run: |
Remove-Item -Force .npmrc
Remove-Item test/mocks/BinaryModule/NuGet.Config
Remove-Item ../PowerShellEditorServices/NuGet.Config
working-directory: vscode-powershell

- name: Deploy NPM configuration
- name: Install PSResources
shell: pwsh
run: Copy-Item .github/workflows/npmrc .npmrc
run: ./vscode-powershell/tools/installPSResources.ps1

- uses: actions/setup-node@v4
with:
Expand All @@ -72,8 +65,7 @@ jobs:
- name: Build, test and package
shell: pwsh
run: Invoke-Build -Configuration Release
env:
NPM_PASSWORD: ${{ secrets.AZURE_NPM_PASSWORD_BASE64 }}
working-directory: vscode-powershell

- name: Upload build artifacts
uses: actions/upload-artifact@v4
Expand Down
13 changes: 0 additions & 13 deletions .github/workflows/npmrc

This file was deleted.

5 changes: 2 additions & 3 deletions test/features/DebugSession.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,8 @@ describe("DebugSessionFeature E2E", function() {
let binaryModulePath: Uri;

before(async function binarySetup() {
if (process.env.TF_BUILD) {
// The binary modules tests won't work in the release pipeline
// due to dependency requirements.
if (!extensions.getExtension("ms-dotnettools.csharp")) {
// These tests require that extension to be installed in the test environment.
this.skip();
}
binaryModulePath = Uri.joinPath(workspace.workspaceFolders![0].uri, "BinaryModule");
Expand Down