Make the place block success check ignore block updates received with no block type changes (#3090)

* Place block fix

* Fix lint

* Use java 16 for older version tests

* Use checkCondition

* lint

* Old versions CI back to Java 1.8 to see if it magically works now

* Add comment

* Revert change to node 18

---------

Co-authored-by: Romain Beaumont <[email protected]>

Author: PondWader

lib/plugins/place_block.js

@@ -10,7 +10,12 @@ function inject (bot) {
 
     let newBlock = bot.blockAt(dest)
     if (oldBlock.type === newBlock.type) {
-      [oldBlock, newBlock] = await onceWithCleanup(bot, `blockUpdate:${dest}`, { timeout: 5000 })
+      [oldBlock, newBlock] = await onceWithCleanup(bot, `blockUpdate:${dest}`, {
+        timeout: 5000,
+        // Condition to wait to receive block update actually changing the block type, in case the bot receives block updates with no changes
+        // oldBlock and newBlock will both be null when the world unloads
+        checkCondition: (oldBlock, newBlock) => !oldBlock || !newBlock || oldBlock.type !== newBlock.type
+      })
     }
 
     // blockUpdate emits (null, null) when the world unloads