Use node 18 on CI (#3157)

* Delete .gitpod.DockerFile

* use node 16 on CI

* replace localhost with 127.0.0.1

* Update index.js

16 to 18

---------

Co-authored-by: Romain Beaumont <[email protected]>

Author: extremeheat

.github/workflows/ci.yml

@@ -12,10 +12,10 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
-    - name: Use Node.js 14.x
+    - name: Use Node.js 18.x
       uses: actions/[email protected]
       with:
-        node-version: 14.x
+        node-version: 18.x
     - run: npm i && npm run lint
 
   MinecraftServer:
@@ -46,7 +46,7 @@ jobs:
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/[email protected]
         with:
-          node-version: 14.x
+          node-version: 18.x
       - name: Setup Java JDK
         uses: actions/[email protected]
         with:

.github/workflows/npm-publish.yml

@@ -13,7 +13,7 @@ jobs:
     - name: Set up Node.js
       uses: actions/setup-node@master
       with:
-        node-version: 14.0.0
+        node-version: 18.0.0
     - id: publish
       uses: JS-DevTools/npm-publish@v1
       with:

.gitpod.DockerFile

@@ -1,4 +1,2 @@
-image:
-  file: .gitpod.DockerFile
 tasks:
 - command: npm install

.gitpod.yml

@@ -1,6 +1,6 @@
-if (typeof process !== 'undefined' && parseInt(process.versions.node.split('.')[0]) < 14) {
+if (typeof process !== 'undefined' && parseInt(process.versions.node.split('.')[0]) < 18) {
   console.error('Your node version is currently', process.versions.node)
-  console.error('Please update it to a version >= 14.x.x from https://nodejs.org/')
+  console.error('Please update it to a version >= 18.x.x from https://nodejs.org/')
   process.exit(1)
 }
 

index.js

@@ -58,7 +58,7 @@ for (const supportedVersion of mineflayer.testedVersions) {
           username: 'flatbot',
           viewDistance: 'tiny',
           port: PORT,
-          host: 'localhost',
+          host: '127.0.0.1',
           version: supportedVersion
         })
         commonTest(bot)
@@ -89,6 +89,7 @@ for (const supportedVersion of mineflayer.testedVersions) {
             console.log(`pinging ${version.minecraftVersion} port : ${PORT}`)
             mc.ping({
               port: PORT,
+              host: '127.0.0.1',
               version: supportedVersion
             }, (err, results) => {
               if (err) return done(err)

test/externalTest.js

@@ -183,7 +183,7 @@ function inject (bot) {
       return run(childBotName)
     }
 
-    const child = spawn('node', [file, 'localhost', `${bot.test.port}`])
+    const child = spawn('node', [file, '127.0.0.1', `${bot.test.port}`])
 
     // Useful to debug child processes:
     child.stdout.on('data', (data) => { console.log(`${data}`) })

test/externalTests/plugins/testCommon.js

@@ -7,7 +7,7 @@ module.exports = () => async (bot) => {
     username: 'spawnbot',
     viewDistance: 'tiny',
     port: bot.test.port,
-    host: 'localhost',
+    host: '127.0.0.1',
     version: bot.version
   })
   await once(spawnBot, 'spawn')