Skip to content

Clean Up Unused Travel Modes #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
daniel-j-h opened this issue Sep 8, 2016 · 1 comment
Open
5 tasks

Clean Up Unused Travel Modes #2879

daniel-j-h opened this issue Sep 8, 2016 · 1 comment

Comments

@daniel-j-h
Copy link
Member

Looking over supported travel modes in #2877 I came across unused travel modes:

// FIXME only for testbot.lua
const constexpr osrm::extractor::TravelMode TRAVEL_MODE_STEPS_UP = 8;
const constexpr osrm::extractor::TravelMode TRAVEL_MODE_STEPS_DOWN = 9;
const constexpr osrm::extractor::TravelMode TRAVEL_MODE_RIVER_UP = 10;
const constexpr osrm::extractor::TravelMode TRAVEL_MODE_RIVER_DOWN = 11;
const constexpr osrm::extractor::TravelMode TRAVEL_MODE_ROUTE = 12;

Let's rip them out for good:

  • remove from travel mode
  • remove in scripting env
  • remove from json travel mode translation
  • adapt testbot profile
  • rip out testbot cucumber tests
@MoKob
Copy link

MoKob commented Sep 13, 2016

The problem here is that if we remove these travel modes, we would also change the API. An assignment, even though not used so far, of these modes would not be possible anymore.

Like so many small changes, we should target their removal for 6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants