Skip to content

original timestamp (ctime, mtime) cannot survive a copy_fs or mirror #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mo-han opened this issue Feb 4, 2021 · 2 comments · Fixed by #463
Closed

original timestamp (ctime, mtime) cannot survive a copy_fs or mirror #450

mo-han opened this issue Feb 4, 2021 · 2 comments · Fixed by #463

Comments

@mo-han
Copy link

mo-han commented Feb 4, 2021

as long as there's actual "copy" operation from one fs to another, then those "touched" files will lost their original ctime or mtime, which would be updated to the time when that copy operation happened.
this is not expected feature. though calling it "critical bug" might be too harsh but still it's much better if it could be fixed.

@althonos
Copy link
Member

One thing we could do would be a preserve_timestamp keyword argument to fs.copy method, and maybe to fs.base.FS.copy as well, that basically attempts to update the (ctime, mtime) after copying.

@mo-han
Copy link
Author

mo-han commented Mar 19, 2021

One thing we could do would be a preserve_timestamp keyword argument ...

Maybe make that default? At least make it defaut for mirror.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants