Skip to content

Commit 515fe7c

Browse files
authored
Merge pull request #951 from bact/remove-powershell
Unify unit test workflow across OSes
2 parents 4debf60 + c86602c commit 515fe7c

File tree

3 files changed

+9
-123
lines changed

3 files changed

+9
-123
lines changed

.github/workflows/unittest-windows.yml

-64
This file was deleted.

.github/workflows/unittest-macos.yml renamed to .github/workflows/unittest.yml

+9-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Unit test and code coverage (macOS)
1+
name: Unit test and code coverage
22

33
on:
44
push:
@@ -17,7 +17,7 @@ jobs:
1717
strategy:
1818
fail-fast: false
1919
matrix:
20-
os: ["macos-latest"]
20+
os: ["macos-latest", "ubuntu-latest", "windows-latest"]
2121
python-version: ["3.10"]
2222

2323
runs-on: ${{ matrix.os }}
@@ -30,20 +30,24 @@ jobs:
3030
with:
3131
python-version: ${{ matrix.python-version }}
3232
cache: "pip"
33-
- name: Print system info
34-
run: sw_vers; python --version; arch
3533
- name: Install build tools
3634
run: |
3735
python -m pip install --upgrade "pip<24.1" "setuptools==73.0.1"
3836
python -m pip install coverage coveralls
39-
- name: Install ICU
37+
- name: Install ICU (macOS)
38+
if: startsWith(matrix.os, 'macos-')
4039
run: |
4140
brew install icu4c
4241
PKG_CONFIG_PATH=$(brew --prefix)/opt/icu4c/lib/pkgconfig
4342
echo "PKG_CONFIG_PATH=${PKG_CONFIG_PATH}" >> "${GITHUB_ENV}"
4443
ICU_VER=$(pkg-config --modversion icu-i18n)
4544
echo "ICU_VER=${ICU_VER}"
4645
echo "ICU_VER=${ICU_VER}" >> "${GITHUB_ENV}"
46+
- name: Install ICU (Windows)
47+
if: startsWith(matrix.os, 'windows-')
48+
run: |
49+
python -m pip install "https://github.com/cgohlke/pyicu-build/releases/download/v2.14/PyICU-2.14-cp310-cp310-win_amd64.whl"
50+
# if needed, get pip wheel link from https://github.com/cgohlke/pyicu-build/releases
4751
- name: Install PyTorch
4852
run: pip install torch
4953
# if needed, get pip wheel link from http://download.pytorch.org/whl/torch/

.github/workflows/unitttest-ubuntu.yml

-54
This file was deleted.

0 commit comments

Comments
 (0)