Skip to content

Update Dockerfile #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bact opened this issue Dec 27, 2024 · 1 comment
Open

Update Dockerfile #1049

bact opened this issue Dec 27, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file help wanted no contributor yet tests Unit test, code coverage, test case
Milestone

Comments

@bact
Copy link
Member

bact commented Dec 27, 2024

  • Current Dockerfile still using 3.8, which is no longer supported.
  • We should update the Dockerfile and other relevant dependencies as well.
    • May have to target more limited set of dependencies in order to avoid dependency conflicts.

Target

  • Updated Dockerfile and docker_requirements.txt
  • They should pass "compact" test suite.
  • They should contain up-to-date dependencies (esp for security updates).

See also

@bact bact added this to PyThaiNLP Dec 27, 2024
@bact bact added help wanted no contributor yet dependencies Pull requests that update a dependency file tests Unit test, code coverage, test case labels Dec 27, 2024
@tassa-yoniso-manasi-karoto
$ docker build -t pythainlp .
[...]
Step 5/6 : RUN if [ -f docker_requirements.txt ]; then pip3 install -r docker_requirements.txt; fi
 ---> Running in ac1af3f12435
Collecting PyYAML==5.4.1 (from -r docker_requirements.txt (line 1))
  Downloading PyYAML-5.4.1-cp38-cp38-manylinux1_x86_64.whl.metadata (2.1 kB)
Collecting attacut==1.0.6 (from -r docker_requirements.txt (line 2))
  Downloading attacut-1.0.6-py3-none-any.whl.metadata (4.0 kB)
Collecting bpemb==0.3.6 (from -r docker_requirements.txt (line 3))
  Downloading bpemb-0.3.6-py3-none-any.whl.metadata (19 kB)
Collecting deepcut==0.7.0.0 (from -r docker_requirements.txt (line 4))
  Downloading deepcut-0.7.0.0-py3-none-any.whl.metadata (600 bytes)
Collecting emoji==0.6.0 (from -r docker_requirements.txt (line 5))
  Downloading emoji-0.6.0.tar.gz (51 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
Collecting epitran==1.25.1 (from -r docker_requirements.txt (line 6))
  Downloading epitran-1.25.1-py2.py3-none-any.whl.metadata (34 kB)
Collecting esupar==1.3.9 (from -r docker_requirements.txt (line 7))
  Downloading esupar-1.3.9-py3-none-any.whl.metadata (6.3 kB)
Collecting fairseq==0.12.2 (from -r docker_requirements.txt (line 8))
  Downloading fairseq-0.12.2-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.whl.metadata (18 kB)
Collecting fastai==1.0.61 (from -r docker_requirements.txt (line 9))
  Downloading fastai-1.0.61-py3-none-any.whl.metadata (14 kB)
Collecting fastcoref==2.1.6 (from -r docker_requirements.txt (line 10))
  Downloading fastcoref-2.1.6.tar.gz (27 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
Collecting gensim==4.3.3 (from -r docker_requirements.txt (line 11))
  Downloading gensim-4.3.3-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (8.3 kB)
ERROR: Ignored the following versions that require a different python version: 3.12.0 Requires-Python >=3.9; 3.12.1 Requires-Python >=3.9
ERROR: Could not find a version that satisfies the requirement h5py==3.12.1 (from versions: 2.2.1, 2.3.0b1, 2.3.0, 2.3.1, 2.4.0b1, 2.4.0, 2.5.0, 2.6.0, 2.7.0rc2, 2.7.0, 2.7.1, 2.8.0rc1, 2.8.0, 2.9.0rc1, 2.9.0, 2.10.0, 3.0.0rc1, 3.0.0, 3.1.0, 3.2.0, 3.2.1, 3.3.0, 3.4.0, 3.5.0, 3.6.0, 3.7.0, 3.8.0, 3.9.0, 3.10.0, 3.11.0)
ERROR: No matching distribution found for h5py==3.12.1
The command '/bin/sh -c if [ -f docker_requirements.txt ]; then pip3 install -r docker_requirements.txt; fi' returned a non-zero code: 1

@bact bact moved this to To do in PyThaiNLP Apr 21, 2025
@bact bact added this to the 5.2 milestone Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted no contributor yet tests Unit test, code coverage, test case
Projects
Status: To do
Development

No branches or pull requests

2 participants