Skip to content

Commit 6126997

Browse files
committed
Sort before comparing dicts in TestChainMap
Sort the results of items() of a dict before comparing them. PyPy apparently does not produce consistent ordering on .items(). Fixes one of the failures from bug #530
1 parent 01a1d31 commit 6126997

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: tests/test_future/test_backports.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@ def test_basics(self):
8787
d['b'] = 20
8888
d['c'] = 30
8989
self.assertEqual(d.maps, [{'b':20, 'c':30}, {'a':1, 'b':2}]) # check internal state
90-
self.assertEqual(d.items(), dict(a=1, b=20, c=30).items()) # check items/iter/getitem
90+
self.assertEqual(sorted(d.items()),
91+
sorted(dict(a=1, b=20, c=30).items())) # check items/iter/getitem
9192
self.assertEqual(len(d), 3) # check len
9293
for key in 'abc': # check contains
9394
self.assertIn(key, d)
@@ -96,7 +97,8 @@ def test_basics(self):
9697

9798
del d['b'] # unmask a value
9899
self.assertEqual(d.maps, [{'c':30}, {'a':1, 'b':2}]) # check internal state
99-
self.assertEqual(d.items(), dict(a=1, b=2, c=30).items()) # check items/iter/getitem
100+
self.assertEqual(sorted(d.items()),
101+
sorted(dict(a=1, b=2, c=30).items())) # check items/iter/getitem
100102
self.assertEqual(len(d), 3) # check len
101103
for key in 'abc': # check contains
102104
self.assertIn(key, d)

0 commit comments

Comments
 (0)