Merge pull request #57 from seuros/main

fix(transports): follow spec guideline

Author: QuantGeekDev

src/core/MCPServer.ts

@@ -432,8 +432,10 @@ export class MCPServer {
       }
       this.isRunning = true;
 
+      const frameworkPackageJson = require('../../package.json');
+      const frameworkVersion = frameworkPackageJson.version || 'unknown';
       const sdkVersion = this.getSdkVersion();
-      logger.info(`Starting MCP server with SDK ${sdkVersion}...`);
+      logger.info(`Starting MCP server (Framework: ${frameworkVersion}, SDK: ${sdkVersion})...`);
 
       const tools = await this.toolLoader.loadTools();
       this.toolsMap = new Map(

src/transports/http/server.ts

@@ -21,6 +21,7 @@ import { logger } from "../../core/Logger.js";
 import { getRequestHeader, setResponseHeaders } from "../../utils/headers.js";
 import { DEFAULT_CORS_CONFIG } from "../sse/types.js";
 import { CORSConfig } from "../sse/types.js";
+import { PING_SSE_MESSAGE } from "../utils/ping-message.js";
 
 function isRequest(msg: JsonRpcMessage): msg is JsonRpcRequest {
   return msg && 
@@ -185,14 +186,15 @@ export class HttpStreamTransport extends AbstractTransport {
           case "POST": await this.handlePost(req, res); break;
           case "GET": await this.handleGet(req, res); break;
           case "DELETE": await this.handleDelete(req, res); break;
-          default:
-             const allowHeader = this._config.enableGetSse ? 
-               'GET, POST, DELETE, OPTIONS' : 
+          default: { // Add block scope for the default case
+             const allowHeader = this._config.enableGetSse ?
+               'GET, POST, DELETE, OPTIONS' :
                'POST, DELETE, OPTIONS';
-             res.writeHead(405, { 'Content-Type': 'text/plain', 'Allow': allowHeader }); 
+             res.writeHead(405, { 'Content-Type': 'text/plain', 'Allow': allowHeader });
              res.end("Method Not Allowed");
-             logger.warn(`Unsupported method: ${req.method}`); 
+             logger.warn(`Unsupported method: ${req.method}`);
              break;
+           } // Close block scope
         }
     } catch (error: any) {
         logger.error(`Error processing ${req.method} ${url.pathname}: ${error.message}`);
@@ -481,7 +483,6 @@ export class HttpStreamTransport extends AbstractTransport {
     if (res.socket) { res.socket.setNoDelay(true); res.socket.setKeepAlive(true); res.socket.setTimeout(0); logger.debug(`Optimized socket for SSE stream ${streamId}`); }
     else { logger.warn(`Could not access socket for SSE stream ${streamId} to optimize.`); }
     this._activeSseConnections.add(connection);
-    res.write(': stream opened\n\n');
     connection.pingInterval = setInterval(() => this.sendPing(connection), 15000);
     if (lastEventId && this._config.resumability.enabled) {
         this.handleResumption(connection, lastEventId, sessionId).catch(err => { logger.error(`Error during stream resumption for ${streamId}: ${err.message}`); this.cleanupConnection(connection, `Resumption error: ${err.message}`); });
@@ -646,7 +647,7 @@ export class HttpStreamTransport extends AbstractTransport {
   private sendPing(connection: ActiveSseConnection): void {
       if (!connection || !connection.res || connection.res.writableEnded) return;
       try {
-          connection.res.write(': keep-alive\n\n');
+          connection.res.write(PING_SSE_MESSAGE);
           logger.debug(`Sent keep-alive ping to stream ${connection.streamId}`);
       } catch (error: any) {
           logger.error(`Error sending ping to stream ${connection.streamId}: ${error.message}`);

src/transports/sse/server.ts

@@ -9,6 +9,7 @@ import { AbstractTransport } from "../base.js"
 import { DEFAULT_SSE_CONFIG, SSETransportConfig, SSETransportConfigInternal, DEFAULT_CORS_CONFIG, CORSConfig } from "./types.js"
 import { logger } from "../../core/Logger.js"
 import { getRequestHeader, setResponseHeaders } from "../../utils/headers.js"
+import { PING_SSE_MESSAGE } from "../utils/ping-message.js";
 
 interface ExtendedIncomingMessage extends IncomingMessage {
   body?: ClientRequest
@@ -225,20 +226,11 @@ export class SSEServerTransport extends AbstractTransport {
     res.write(`event: endpoint\ndata: ${endpointUrl}\n\n`)
 
     logger.debug('Sending initial keep-alive')
-    res.write(": keep-alive\n\n")
 
     this._keepAliveInterval = setInterval(() => {
       if (this._sseResponse && !this._sseResponse.writableEnded) {
         try {
-          logger.debug('Sending keep-alive ping')
-          this._sseResponse.write(": keep-alive\n\n")
-          
-          const pingMessage = {
-            jsonrpc: "2.0",
-            method: "ping",
-            params: { timestamp: Date.now() }
-          }
-          this._sseResponse.write(`data: ${JSON.stringify(pingMessage)}\n\n`)
+          this._sseResponse.write(PING_SSE_MESSAGE);
         } catch (error) {
           logger.error(`Error sending keep-alive: ${error}`)
           this.cleanupConnection()

src/transports/utils/ping-message.ts

@@ -0,0 +1,5 @@
+/**
+ * Pre-stringified JSON-RPC ping message formatted for Server-Sent Events (SSE).
+ * Includes the 'data: ' prefix and trailing newlines.
+ */
+export const PING_SSE_MESSAGE = 'data: {"jsonrpc":"2.0","method":"ping"}\n\n';

tsconfig.json

@@ -9,7 +9,8 @@
     "strict": true,
     "esModuleInterop": true,
     "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    "resolveJsonModule": true
   },
   "include": ["src/**/*"],
   "exclude": ["node_modules", "**/*.test.ts"]