Skip to content

Commit 080a9e1

Browse files
committed
Revert "[Clang][Driver] Enable internalization by default for AMDGPU (llvm#138365)"
This reverts commit 2b62a31.
1 parent b62c1eb commit 080a9e1

File tree

3 files changed

+0
-19
lines changed

3 files changed

+0
-19
lines changed

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9508,12 +9508,6 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA,
95089508
CmdArgs.push_back(Args.MakeArgString(
95099509
"--device-linker=" + TC->getTripleString() + "=" + Arg));
95109510

9511-
// Enable internalization for AMDGPU.
9512-
if (TC->getTriple().isAMDGPU())
9513-
CmdArgs.push_back(
9514-
Args.MakeArgString("--device-linker=" + TC->getTripleString() +
9515-
"=-plugin-opt=-amdgpu-internalize-symbols"));
9516-
95179511
// Forward the LTO mode relying on the Driver's parsing.
95189512
if (C.getDriver().getOffloadLTOMode() == LTOK_Full)
95199513
CmdArgs.push_back(Args.MakeArgString(

clang/test/Driver/hip-options.hip

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,3 @@
259259
// RUN: --offload-arch=gfx1100 --offload-new-driver --offload-jobs=0x4 %s 2>&1 | \
260260
// RUN: FileCheck -check-prefix=INVJOBS %s
261261
// INVJOBS: clang: error: invalid integral value '0x4' in '--offload-jobs=0x4'
262-
263-
// Check that internalization is enabled for offloading on AMDGPU.
264-
// RUN: %clang -### -Werror --target=x86_64-unknown-linux-gnu -nogpuinc -nogpulib \
265-
// RUN: --offload-arch=gfx1100 --offload-new-driver %s 2>&1 | \
266-
// RUN: FileCheck -check-prefix=INTERNALIZATION %s
267-
// INTERNALIZATION: --device-linker=amdgcn-amd-amdhsa=-plugin-opt=-amdgpu-internalize-symbols

clang/test/Driver/openmp-offload-gpu.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -397,10 +397,3 @@
397397
// RUN: --offload-arch=sm_52 -foffload-lto=thin -nogpulib -nogpuinc %s 2>&1 \
398398
// RUN: | FileCheck --check-prefix=THINLTO-SM52 %s
399399
// THINLTO-SM52: --device-compiler=nvptx64-nvidia-cuda=-flto=thin
400-
401-
// Check that internalization is enabled for OpenMP offloading on AMDGPU.
402-
//
403-
// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp=libomp \
404-
// RUN: --offload-arch=gfx906 -nogpulib -nogpuinc %s 2>&1 \
405-
// RUN: | FileCheck --check-prefix=INTERNALIZATION-GFX906 %s
406-
// INTERNALIZATION-GFX906: --device-linker=amdgcn-amd-amdhsa=-plugin-opt=-amdgpu-internalize-symbols

0 commit comments

Comments
 (0)