Skip to content

Commit 3d63f42

Browse files
committed
Auto merge of rust-lang#3272 - RalfJung:jobserver, r=RalfJung
update comment about CARGO_MAKEFLAGS
2 parents 70e720b + 80874d3 commit 3d63f42

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/tools/miri/cargo-miri/src/phases.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -501,11 +501,10 @@ pub fn phase_runner(mut binary_args: impl Iterator<Item = String>, phase: Runner
501501
// Set missing env vars. We prefer build-time env vars over run-time ones; see
502502
// <https://github.com/rust-lang/miri/issues/1661> for the kind of issue that fixes.
503503
for (name, val) in info.env {
504-
// `CARGO_MAKEFLAGS` contains information about how to reach the
505-
// jobserver, but by the time the program is being run, that jobserver
506-
// no longer exists. Hence we shouldn't forward this.
507-
// FIXME: Miri builds the final crate without a jobserver.
508-
// This may be fixed with github.com/rust-lang/cargo/issues/12597.
504+
// `CARGO_MAKEFLAGS` contains information about how to reach the jobserver, but by the time
505+
// the program is being run, that jobserver no longer exists (cargo only runs the jobserver
506+
// for the build portion of `cargo run`/`cargo test`). Hence we shouldn't forward this.
507+
// Also see <https://github.com/rust-lang/rust/pull/113730>.
509508
if name == "CARGO_MAKEFLAGS" {
510509
continue;
511510
}

0 commit comments

Comments
 (0)