Skip to content

3.x: Test consumer method renames #6527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akarnokd opened this issue Jun 20, 2019 · 2 comments
Closed

3.x: Test consumer method renames #6527

akarnokd opened this issue Jun 20, 2019 · 2 comments
Labels
3.x Discussion
Milestone
3.0

Comments

@akarnokd
Copy link
Member

The feedback for the test consumers called for a few method renames (#6153):

  • assertResult - test for values received followed by completion
  • assertFailure - test for values received followed by error
  • assertEmpty - test for no onNext/onError/onComplete signals
  • assertValuesOnly - test for values received but no termination
  • awaitDone - wait for termination via blocking or report timeout

Suggestions for better, more apt and hopefully not too long names are welcome.
@akarnokd akarnokd added this to the 3.0 milestone Jun 20, 2019
@vanniktech
Copy link
Collaborator

I like the names as they are.

@maryang710
Copy link

I like it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x Discussion
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@akarnokd @maryang710 @vanniktech