Skip to content

Commit 0f0d2d1

Browse files
authored
Merge pull request #59 from mbonneau/retryWhen_skip
Remove skipped `retryWhen` test make `retryWhen` correction
2 parents d0fc1f8 + e8e44ea commit 0f0d2d1

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

lib/Rx/Operator/RetryWhenOperator.php

+4-1
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,11 @@ function ($x) use ($subscribeToSource, &$sourceError) {
9090
}
9191
},
9292
[$observer, 'onError'],
93-
function () use (&$innerCompleted) {
93+
function () use (&$innerCompleted, &$sourceError, $observer) {
9494
$innerCompleted = true;
95+
if ($sourceError) {
96+
$observer->onCompleted();
97+
}
9598
}
9699
), $scheduler);
97100

test/Rx/Functional/Operator/RetryWhenTest.php

-2
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,6 @@ public function retryWhen_Observable_complete()
204204
*/
205205
public function retryWhen_Observable_next_complete()
206206
{
207-
$this->markTestSkipped("skip until takeWhile is implemented");
208-
209207
$error = new \Exception();
210208

211209
$xs = $this->createColdObservable([

0 commit comments

Comments
 (0)